Closed
Bug 776077
Opened 11 years ago
Closed 11 years ago
Hundreds of -Wconversion warnings in cairo for "implicit conversion from enumeration type 'cairo_status_t'" and related
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
994 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Nearly half of our existing Clang warnings (375 on my last build) are -Wconversion warnings in cairo that look like this: gfx/cairo/cairo/src/cairo-quartz-surface.c:2710:9 [-Wconversion] implicit conversion from enumeration type 'enum _cairo_status' to different enumeration type 'cairo_int_status_t' (aka 'enum _cairo_int_status') gfx/cairo/cairo/src/cairo-quartz-surface.c:2715:10 [-Wconversion] implicit conversion from enumeration type 'cairo_status_t' (aka 'enum _cairo_status') to different enumeration type 'cairo_int_status_t' (aka 'enum _cairo_int_status') These account for 375 of the 380 warnings in gfx/cairo and 375 of the 489 warnings in gfx/. There are 812 total compiler warnings in the tree when building Firefox. So, this is the largest single batch of related warnings in the code base.
Assignee | ||
Updated•11 years ago
|
Blocks: clang-macosx
Comment 1•11 years ago
|
||
I don't know a good way to fix this problem. It might be best to just disable this warning for the cairo directory.
Assignee | ||
Comment 2•11 years ago
|
||
Not my preferred solution (actually fixing the warnings), but better than nothing. Try at https://tbpl.mozilla.org/?tree=Try&rev=9638877dac55
Updated•11 years ago
|
Attachment #653454 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/55b7ad1fd651
Target Milestone: --- → mozilla17
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/55b7ad1fd651
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•