Last Comment Bug 776203 - Add virtual dtor to GeckoContentController
: Add virtual dtor to GeckoContentController
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Doug Sherk (:drs) (inactive)
:
Mentors:
Depends on: 750974
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-20 20:01 PDT by Doug Sherk (:drs) (inactive)
Modified: 2012-07-23 03:06 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add virtual dtor to GeckoContentController (874 bytes, patch)
2012-07-20 20:03 PDT, Doug Sherk (:drs) (inactive)
gal: review+
Details | Diff | Splinter Review

Description Doug Sherk (:drs) (inactive) 2012-07-20 20:01:41 PDT
Causing warnings without this due to refcounting and that this class is abstract.
Comment 1 Doug Sherk (:drs) (inactive) 2012-07-20 20:03:05 PDT
Created attachment 644577 [details] [diff] [review]
Add virtual dtor to GeckoContentController

Proposed patch
Comment 2 David Zbarsky (:dzbarsky) 2012-07-22 13:44:42 PDT
I got tired of seeing this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb0be101427
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-22 19:04:31 PDT
https://hg.mozilla.org/mozilla-central/rev/7eb0be101427
Comment 4 :Ms2ger 2012-07-23 03:06:39 PDT
Comment on attachment 644577 [details] [diff] [review]
Add virtual dtor to GeckoContentController

Review of attachment 644577 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/GeckoContentController.h
@@ +22,5 @@
>     */
>    virtual void RequestContentRepaint(const FrameMetrics& aFrameMetrics) = 0;
> +
> +  GeckoContentController() {};
> +  virtual ~GeckoContentController() {};

I bet clang is going to warn about the trailing ;s.

Note You need to log in before you can comment on or make changes to this bug.