The default bug view has changed. See this FAQ.

Add virtual dtor to GeckoContentController

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Causing warnings without this due to refcounting and that this class is abstract.
(Assignee)

Comment 1

5 years ago
Created attachment 644577 [details] [diff] [review]
Add virtual dtor to GeckoContentController

Proposed patch
Attachment #644577 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Depends on: 750974

Updated

5 years ago
Attachment #644577 - Flags: review?(bzbarsky) → review+
I got tired of seeing this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb0be101427
Assignee: nobody → bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/7eb0be101427
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 644577 [details] [diff] [review]
Add virtual dtor to GeckoContentController

Review of attachment 644577 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/GeckoContentController.h
@@ +22,5 @@
>     */
>    virtual void RequestContentRepaint(const FrameMetrics& aFrameMetrics) = 0;
> +
> +  GeckoContentController() {};
> +  virtual ~GeckoContentController() {};

I bet clang is going to warn about the trailing ;s.
You need to log in before you can comment on or make changes to this bug.