Closed
Bug 776203
Opened 13 years ago
Closed 13 years ago
Add virtual dtor to GeckoContentController
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: drs, Assigned: drs)
References
Details
Attachments
(1 file)
|
874 bytes,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
Causing warnings without this due to refcounting and that this class is abstract.
|
||
Updated•13 years ago
|
Attachment #644577 -
Flags: review?(bzbarsky) → review+
|
||
Comment 2•13 years ago
|
||
I got tired of seeing this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb0be101427
Assignee: nobody → bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → mozilla17
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 4•13 years ago
|
||
Comment on attachment 644577 [details] [diff] [review]
Add virtual dtor to GeckoContentController
Review of attachment 644577 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/ipc/GeckoContentController.h
@@ +22,5 @@
> */
> virtual void RequestContentRepaint(const FrameMetrics& aFrameMetrics) = 0;
> +
> + GeckoContentController() {};
> + virtual ~GeckoContentController() {};
I bet clang is going to warn about the trailing ;s.
You need to log in
before you can comment on or make changes to this bug.
Description
•