Closed Bug 776243 Opened 9 years ago Closed 9 years ago

Unpref WebGL context bindings

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

No description provided.
Summary: Unpref WebGL → Unpref WebGL context bindings
Depends on: 788525
Attached patch Patch v1Splinter Review
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #658842 - Flags: review?(jst)
Comment on attachment 658842 [details] [diff] [review]
Patch v1

I unfortunately didn't get to this today as I had hoped to, and I'll be out for the next week and a half, so maybe peterv can get to this one sooner? If not, I'm happy to review after I'm back at work on the 19th.
Attachment #658842 - Flags: review?(jst) → review?(peterv)
Comment on attachment 658842 [details] [diff] [review]
Patch v1

Review of attachment 658842 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.h
@@ +470,5 @@
> +        UNPACK_FLIP_Y_WEBGL = 0x9240,
> +        UNPACK_PREMULTIPLY_ALPHA_WEBGL = 0x9241,
> +        CONTEXT_LOST_WEBGL = 0x9242,
> +        UNPACK_COLORSPACE_CONVERSION_WEBGL = 0x9243,
> +        BROWSER_DEFAULT_WEBGL = 0x9244

Ugh, we should expose the webidl consts somehow.
Attachment #658842 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/f6778c068c03
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
This is awesome.  Thank you!
Can we also get rid of nsIWebGLUniformLocation and such now?
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.