Closed
Bug 776243
Opened 13 years ago
Closed 13 years ago
Unpref WebGL context bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
159.31 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•13 years ago
|
Summary: Unpref WebGL → Unpref WebGL context bindings
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Comment on attachment 658842 [details] [diff] [review]
Patch v1
I unfortunately didn't get to this today as I had hoped to, and I'll be out for the next week and a half, so maybe peterv can get to this one sooner? If not, I'm happy to review after I'm back at work on the 19th.
Attachment #658842 -
Flags: review?(jst) → review?(peterv)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 658842 [details] [diff] [review]
Patch v1
Review of attachment 658842 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/canvas/src/WebGLContext.h
@@ +470,5 @@
> + UNPACK_FLIP_Y_WEBGL = 0x9240,
> + UNPACK_PREMULTIPLY_ALPHA_WEBGL = 0x9241,
> + CONTEXT_LOST_WEBGL = 0x9242,
> + UNPACK_COLORSPACE_CONVERSION_WEBGL = 0x9243,
> + BROWSER_DEFAULT_WEBGL = 0x9244
Ugh, we should expose the webidl consts somehow.
Attachment #658842 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
|
|
||
Comment 6•13 years ago
|
||
This is awesome. Thank you!
|
|
||
Comment 7•13 years ago
|
||
Can we also get rid of nsIWebGLUniformLocation and such now?
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•