776254 - Keyboard Shortcut Ctrl+Shift+J (Open Error Console) does not work in 21 July Nightly build

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/446b788ab99d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120721041038

Keyboard Shortcut Ctrl+Shift+J (Open Error Console) does not work in Windows build(It works in Ubuntu).

Comment 1

[B.J. Herbison]

The "works in Ubuntu" was my report, but after that I updated to the current build and the key combination doesn't work. (Several other key combinations work.)

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

intended ? https://bugzilla.mozilla.org/show_bug.cgi?id=765564#c27

Comment 3

[B.J. Herbison]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #2)
> intended ? https://bugzilla.mozilla.org/show_bug.cgi?id=765564#c27

If it was intended it was a sloppy removal. I created a new profile and installed keyconfig and Error Console is still listed as being bound to Ctrl+Shift+J. Also, the Firefox menu entry for Error Console still lists Ctrl+Shift+J as the binding.

Comment 4

[Paul Rouget [:paul]]

(working on it)

Comment 5

[Paul Rouget [:paul]]

Attachment: v1

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 644957 [details] [diff] [review]
v1

This looks like the key combo would always open the console regardless of the broadcaster's state.

Comment 7

[Paul Rouget [:paul]]

Right. And we have this problem with all the tools.

Comment 8

[Paul Rouget [:paul]]

Attachment: v1.1

Comment 9

[Paul Rouget [:paul]]

Comment on attachment 645017 [details] [diff] [review]
v1.1

Rob, can you take a look at this before I go through the browser review again?

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 645017 [details] [diff] [review]
v1.1

diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

In the section enabling tools for each pref, you might use a Map of pref name to element id and iterate through those to do the removeAttribute("disabled"|"hidden") bits. Will cut down on a bit of the patch size.

Otherwise, this looks fine.

Comment 11

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #10)
> Comment on attachment 645017 [details] [diff] [review]
> v1.1
> 
> diff --git a/browser/base/content/browser.js
> b/browser/base/content/browser.js
> 
> In the section enabling tools for each pref, you might use a Map of pref
> name to element id and iterate through those to do the
> removeAttribute("disabled"|"hidden") bits. Will cut down on a bit of the
> patch size.

I will do that in a followup bug (or in the future devtools.jsm file).

Comment 12

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=c77e9ebe89bb

Comment 13

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/a4ce9e1d4135

Comment 14

[Paul Rouget [:paul]]

https://hg.mozilla.org/mozilla-central/rev/a4ce9e1d4135

Comment 15

[Md. Ehsanul Hassan]

i have reproduce this bug on nightly 17.0a1 windows 10 64 bit
 Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
and verified on firefox 54.0b7
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 
[testday-20170512]