Note: There are a few cases of duplicates in user autocompletion which are being worked on.

function.toString() is missing trailing }

RESOLVED FIXED in Firefox 17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Alice0775 White, Assigned: Benjamin)

Tracking

({regression})

17 Branch
mozilla17
x86
All
regression
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/446b788ab99d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120721041038

For ex. evaluate the following code in Scratchpad(need chrome right)
alert( getBrowserSelection.toString() )
Then there is missing trailing }

Step To Reproduced
1. Open Firefox with Clean profile
2. Set devtools.chrome.enabled = true in about:config
3. Open Scratchpad (Shift+F4) and Environment > Browser checked
4. Run alert( getBrowserSelection.toString() )

Actual Results
  missing trailing }
 
Expected Resuls
  Should not

Regression window:
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6e09c52e2c73
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120720111908
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f9b341d6babd
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120720112708
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6e09c52e2c73&tochange=f9b341d6babd


Regressed by Bug 761723
(Assignee)

Comment 1

5 years ago
The source needs to be decoded with nsScriptLoader::ConvertToUTF16 before being passed to the JS engine.
(Assignee)

Comment 2

5 years ago
Created attachment 644698 [details] [diff] [review]
decode the source properly
Assignee: general → bpeterson
(Assignee)

Comment 3

5 years ago
Created attachment 644759 [details] [diff] [review]
decode source properly
Attachment #644698 - Attachment is obsolete: true
Attachment #644759 - Flags: review?(bzbarsky)

Comment 4

5 years ago
Comment on attachment 644759 [details] [diff] [review]
decode source properly

r=me
Attachment #644759 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1485b7d63b61
https://hg.mozilla.org/mozilla-central/rev/1485b7d63b61
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
no need to track for 17, it's fixed. adjusting flags accordingly.
status-firefox17: --- → fixed
tracking-firefox17: ? → ---

Comment 8

5 years ago
I verified on Windows 7 X86, Ubuntu X32 and Mac 10.8 and it is not reproducing on Firefox 17.0b5.
You need to log in before you can comment on or make changes to this bug.