Closed
Bug 776314
Opened 12 years ago
Closed 12 years ago
"Assertion failure: src->length() > 0 && chars[0] == '(',"
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: gkw, Assigned: Benjamin)
References
Details
(Keywords: assertion, regression, testcase, Whiteboard: [js:t])
Attachments
(3 files)
5.11 KB,
text/plain
|
Details | |
5.64 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
1.52 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
disassemble(eval(("(function(){(a for each (e in b));})"))); asserts js debug shell on m-c changeset defbe00ca091 without any CLI arguments at Assertion failure: src->length() > 0 && chars[0] == '(',
Reporter | ||
Comment 1•12 years ago
|
||
autoBisect shows this is probably related to the following changeset: The first bad revision is: changeset: 99950:e080642175e6 user: Benjamin Peterson date: Fri Jul 20 20:17:38 2012 +0200 summary: Bug 761723 - Save script sources to implement Function.prototype.toString. r=jorendorff,njn,jimb,jst,Ms2ger
Blocks: savesource
Assignee | ||
Comment 2•12 years ago
|
||
What do people think toSource() of a generator expression should be?
Assignee | ||
Comment 4•12 years ago
|
||
Assignee: general → bpeterson
Attachment #645168 -
Flags: review?(n.nethercote)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #645169 -
Flags: review?(n.nethercote)
Assignee | ||
Updated•12 years ago
|
Attachment #645168 -
Flags: review?(n.nethercote) → review?(luke)
Assignee | ||
Updated•12 years ago
|
Attachment #645169 -
Flags: review?(n.nethercote) → review?(luke)
Updated•12 years ago
|
Whiteboard: [js:t]
Updated•12 years ago
|
Attachment #645168 -
Flags: review?(luke) → review+
Comment 6•12 years ago
|
||
Comment on attachment 645169 [details] [diff] [review] stub out genexp toSource calls >+ if (isInterpreted() && script()->isGeneratorExp) { >+ if ((!bodyOnly && !out.append("function genexp() {")) || >+ !out.append("\n [generator expression]\n") || >+ (!bodyOnly && !out.append("}"))) >+ return NULL; >+ return out.finishString(); Multi-line conditional needs braced then-branch.
Attachment #645169 -
Flags: review?(luke) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f939ff2f29fb https://hg.mozilla.org/integration/mozilla-inbound/rev/08c6cc749ee6
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f939ff2f29fb https://hg.mozilla.org/mozilla-central/rev/08c6cc749ee6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment 9•11 years ago
|
||
Automatically extracted testcase for this bug was committed: https://hg.mozilla.org/mozilla-central/rev/efaf8960a929
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•