Closed
Bug 776317
Opened 13 years ago
Closed 13 years ago
toString and toSource allow closing "}" to end up in a line-comment
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
mozilla17
People
(Reporter: jruderman, Assigned: Benjamin)
References
Details
(Keywords: regression, testcase, Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
10.49 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
js> new Function("//")
(function anonymous() { // })
Maybe the stored source for "new Function()" should get line breaks before and after the input.
|
||
Updated•13 years ago
|
tracking-firefox17:
--- → ?
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: general → bpeterson
Attachment #644761 -
Flags: review?(luke)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Same thing as above with other tests that depend on the value updated.
Attachment #644761 -
Attachment is obsolete: true
Attachment #644761 -
Flags: review?(luke)
Attachment #644764 -
Flags: review?(luke)
|
|
||
Updated•13 years ago
|
Attachment #644764 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Does this have tests or need tests?
Flags: in-testsuite?
Whiteboard: [qa-]
|
|
||
Comment 7•13 years ago
|
||
Tests got landed in the checkin. VERIFIED too.
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•