Last Comment Bug 776317 - toString and toSource allow closing "}" to end up in a line-comment
: toString and toSource allow closing "}" to end up in a line-comment
: regression, testcase
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: :Benjamin Peterson
Depends on:
Blocks: jsfunfuzz savesource
  Show dependency treegraph
Reported: 2012-07-21 22:27 PDT by Jesse Ruderman
Modified: 2012-10-17 15:56 PDT (History)
6 users (show)
gary: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

add newlines (3.67 KB, patch)
2012-07-22 08:04 PDT, :Benjamin Peterson
no flags Details | Diff | Review
add newlines to Function constructor bodies (10.49 KB, patch)
2012-07-22 09:47 PDT, :Benjamin Peterson
luke: review+
Details | Diff | Review

Description Jesse Ruderman 2012-07-21 22:27:24 PDT
js> new Function("//")
(function anonymous() { // })

Maybe the stored source for "new Function()" should get line breaks before and after the input.
Comment 1 :Benjamin Peterson 2012-07-22 08:04:46 PDT
Created attachment 644761 [details] [diff] [review]
add newlines
Comment 2 :Benjamin Peterson 2012-07-22 09:47:17 PDT
Created attachment 644764 [details] [diff] [review]
add newlines to Function constructor bodies

Same thing as above with other tests that depend on the value updated.
Comment 4 Ed Morley [:emorley] 2012-07-24 02:57:59 PDT
Comment 5 Lukas Blakk [:lsblakk] use ?needinfo 2012-07-30 11:43:44 PDT
Glad this is fixed, no need to track for 17.
Comment 6 Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2012-10-17 15:54:56 PDT
Does this have tests or need tests?
Comment 7 Gary Kwong [:gkw] [:nth10sd] 2012-10-17 15:56:01 PDT
Tests got landed in the checkin. VERIFIED too.
Comment 8 Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2012-10-17 15:56:36 PDT
Thanks Gary.

Note You need to log in before you can comment on or make changes to this bug.