toString and toSource allow closing "}" to end up in a line-comment

VERIFIED FIXED in Firefox 17

Status

()

Core
JavaScript Engine
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: Benjamin)

Tracking

(Blocks: 1 bug, {regression, testcase})

Trunk
mozilla17
x86_64
Mac OS X
regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17- verified)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
js> new Function("//")
(function anonymous() { // })

Maybe the stored source for "new Function()" should get line breaks before and after the input.
tracking-firefox17: --- → ?
(Assignee)

Comment 1

5 years ago
Created attachment 644761 [details] [diff] [review]
add newlines
Assignee: general → bpeterson
Attachment #644761 - Flags: review?(luke)
(Assignee)

Comment 2

5 years ago
Created attachment 644764 [details] [diff] [review]
add newlines to Function constructor bodies

Same thing as above with other tests that depend on the value updated.
Attachment #644761 - Attachment is obsolete: true
Attachment #644761 - Flags: review?(luke)
Attachment #644764 - Flags: review?(luke)

Updated

5 years ago
Attachment #644764 - Flags: review?(luke) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e10777e674cb

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e10777e674cb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Glad this is fixed, no need to track for 17.
status-firefox17: --- → fixed
tracking-firefox17: ? → -
Does this have tests or need tests?
Flags: in-testsuite?
Whiteboard: [qa-]
Tests got landed in the checkin. VERIFIED too.
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
Thanks Gary.
status-firefox17: fixed → verified
You need to log in before you can comment on or make changes to this bug.