776333 - "ASSERTION: We forgot to Morph a slim wrapper!" with Components.lookupMethod

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

###!!! ASSERTION: We forgot to Morph a slim wrapper!: 'clasp->ext.innerObject || IS_WN_WRAPPER_OBJECT(obj)', file js/xpconnect/wrappers/WrapperFactory.cpp, line 283

Assertion failure: (DebugCheckWrapperClass(obj) && !js::GetReservedSlot(obj, 0).isDouble()), at js/xpconnect/wrappers/XrayWrapper.cpp:440

Might be a regression from bug 774245.

Comment 1

[Jesse Ruderman]

Attachment: stack traces

Comment 3

[Bobby Holley (:bholley)]

Attachment: Morph slim wrappers in LookupMethod. v1

We're not going through PrepareForUnwrapping, so we need to manually morph slim wrappers.

Comment 4

[Bobby Holley (:bholley)]

pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/8eaf364324ce

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8eaf364324ce

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0

Verified the fix on latest Firefox 17 beta debug build on Mac Os X 10.7.5 and doesn't assert.
Marking verified for Firefox 17.

Comment 7

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old