The default bug view has changed. See this FAQ.

"ASSERTION: Should not use nsSVGIntegrationUtils on this SVG frame"

VERIFIED FIXED in Firefox 16

Status

()

Core
SVG
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: jwatt)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla17
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox15 unaffected, firefox16+ verified, firefox17 verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 644736 [details]
testcase

###!!! ASSERTION: Should not use nsSVGIntegrationUtils on this SVG frame: '!svgChildFrame || (NS_SVGDisplayListPaintingEnabled() && !(aFrame->GetStateBits() & NS_STATE_SVG_NONDISPLAY_CHILD))', file layout/svg/base/src/nsSVGIntegrationUtils.cpp, line 390
(Reporter)

Comment 1

5 years ago
Created attachment 644737 [details]
stack trace
(Assignee)

Comment 2

5 years ago
Created attachment 647343 [details] [diff] [review]
patch

The assertion is getting upset because nsSVGOuterSVGFrame implements nsISVGChildFrame. The assertion should just check for the NS_FRAME_SVG_LAYOUT bit instead of nsISVGChildFrame.
Assignee: nobody → jwatt
Attachment #647343 - Flags: review?(roc)
(Assignee)

Comment 3

5 years ago
The test in bug 768351 is essentially the same as this one, which is why I didn't include it in this patch as a crashtest.
Attachment #647343 - Flags: review?(roc) → review+
(Assignee)

Comment 4

5 years ago
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/eaa1c9822d8a
Blocks: 768351
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/eaa1c9822d8a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
status-firefox15: --- → unaffected
status-firefox16: --- → affected
status-firefox17: --- → fixed
tracking-firefox16: --- → ?
(Assignee)

Comment 6

5 years ago
Comment on attachment 647343 [details] [diff] [review]
patch

[Approval Request Comment]

The real bug we want to fix on aurora is bug 779403, but that bug depends on the fix in bug 768351, which in turn depends on the fix in this bug, so requesting approval on this patch.

Bug caused by (feature/regressing bug #): 738192
User impact if declined: SVG masking is broken
Testing completed (on m-c, etc.): patch has been on m-c for several days
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none
Attachment #647343 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 7

5 years ago
Err, for "Risk to taking this patch (and alternatives if risky)" I seem to have only processed the "alternatives" part. The risk is very low though, but yeah, there aren't really any viable alternatives.
tracking-firefox16: ? → +
Attachment #647343 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 8

5 years ago
Pushed https://hg.mozilla.org/releases/mozilla-aurora/rev/ca633397362e
status-firefox16: affected → fixed
Keywords: verifyme
Saw the assertion on 2012-07-22-mozilla-central-debug build.
Verified fixed on FF 16 2012-09-19-mozilla-beta-debug build on Mac OS X 10.7.4.
status-firefox16: fixed → verified
QA Contact: paul.silaghi
Verified fixed on FF 17 2012-10-15-mozilla-beta-debug build on Mac OS X 10.7.4.
Status: RESOLVED → VERIFIED
status-firefox17: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.