Last Comment Bug 776447 - layout/xul/base/src/nsSliderFrame.cpp(595) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'
: layout/xul/base/src/nsSliderFrame.cpp(595) : warning C4305: 'return' : trunca...
Product: Core
Classification: Components
Component: XUL (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla17
Assigned To: Makoto Kato [:m_kato]
: Neil Deakin
Depends on:
Blocks: 732052
  Show dependency treegraph
Reported: 2012-07-23 00:52 PDT by Makoto Kato [:m_kato]
Modified: 2012-07-24 02:57 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (982 bytes, patch)
2012-07-23 00:55 PDT, Makoto Kato [:m_kato]
enndeakin: review+
Details | Diff | Splinter Review

Description User image Makoto Kato [:m_kato] 2012-07-23 00:52:15 PDT
don't use NS_ENSURE_ARG_POINTER for boolean.  NS_ERROR_xxxx will convert to true.
Comment 1 User image Makoto Kato [:m_kato] 2012-07-23 00:55:24 PDT
Created attachment 644856 [details] [diff] [review]
Comment 2 User image Makoto Kato [:m_kato] 2012-07-23 00:56:25 PDT
Comment on attachment 644856 [details] [diff] [review]

This is a regression by bug 732052.  return type is bool, so we should not use NS_ENSURE_ARG_POINTER.
Comment 3 User image Neil Deakin 2012-07-23 06:54:16 PDT
Comment on attachment 644856 [details] [diff] [review]

Good catch. Thanks.
Comment 5 User image Ed Morley [:emorley] 2012-07-24 02:57:10 PDT

Note You need to log in before you can comment on or make changes to this bug.