The default bug view has changed. See this FAQ.

layout/xul/base/src/nsSliderFrame.cpp(595) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'

RESOLVED FIXED in mozilla17

Status

()

Core
XUL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
don't use NS_ENSURE_ARG_POINTER for boolean.  NS_ERROR_xxxx will convert to true.
(Assignee)

Comment 1

5 years ago
Created attachment 644856 [details] [diff] [review]
fix
(Assignee)

Comment 2

5 years ago
Comment on attachment 644856 [details] [diff] [review]
fix

This is a regression by bug 732052.  return type is bool, so we should not use NS_ENSURE_ARG_POINTER.
Attachment #644856 - Flags: review?(wjohnston)

Comment 3

5 years ago
Comment on attachment 644856 [details] [diff] [review]
fix

Good catch. Thanks.
Attachment #644856 - Flags: review?(wjohnston) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/36daa5515bc8
Assignee: nobody → m_kato
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/36daa5515bc8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.