Closed Bug 776447 Opened 10 years ago Closed 10 years ago

layout/xul/base/src/nsSliderFrame.cpp(595) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

don't use NS_ENSURE_ARG_POINTER for boolean.  NS_ERROR_xxxx will convert to true.
Attached patch fixSplinter Review
Comment on attachment 644856 [details] [diff] [review]
fix

This is a regression by bug 732052.  return type is bool, so we should not use NS_ENSURE_ARG_POINTER.
Attachment #644856 - Flags: review?(wjohnston)
Comment on attachment 644856 [details] [diff] [review]
fix

Good catch. Thanks.
Attachment #644856 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/36daa5515bc8
Assignee: nobody → m_kato
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/36daa5515bc8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.