Closed
Bug 776447
Opened 13 years ago
Closed 13 years ago
layout/xul/base/src/nsSliderFrame.cpp(595) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
982 bytes,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
don't use NS_ENSURE_ARG_POINTER for boolean. NS_ERROR_xxxx will convert to true.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 644856 [details] [diff] [review]
fix
This is a regression by bug 732052. return type is bool, so we should not use NS_ENSURE_ARG_POINTER.
Attachment #644856 -
Flags: review?(wjohnston)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 644856 [details] [diff] [review]
fix
Good catch. Thanks.
Attachment #644856 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Assignee: nobody → m_kato
Target Milestone: --- → mozilla17
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•