Closed Bug 776480 Opened 10 years ago Closed 10 years ago

B2G RIL: missing handler for ipc message 'RIL:GetRadioState'

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: hsinyi, Assigned: allstars.chh)

References

Details

Attachments

(1 file)

In 'RILContentHelper.js' we send a sync message 'RIL:GetRadioState' to request radio info. However, there is no corresponding handler for this ipc message.
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> In 'RILContentHelper.js' we send a sync message 'RIL:GetRadioState' to
> request radio info. However, there is no corresponding handler for this ipc
> message.

Seems this is the regression of 762760? Maybe we should replace "RIL:GetRadioState" with "RIL:GetRilContext" ?
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> > In 'RILContentHelper.js' we send a sync message 'RIL:GetRadioState' to
> > request radio info. However, there is no corresponding handler for this ipc
> > message.
> 
> Seems this is the regression of bug 762760 ? Maybe we should replace
> "RIL:GetRadioState" with "RIL:GetRilContext" ?
Blocks: b2g-ril
Yes, good find. Can you fix? Thanks!
I'll take it since it's my mistake.
Thanks for spotting this.
Assignee: nobody → allstars.chh
OS: Linux → Gonk
Hardware: x86_64 → ARM
Attached patch PatchSplinter Review
rename IPC message "GetRadioState" to "GetRilContext" in RILContentHelper.js
Attachment #645218 - Flags: review?(philipp)
Attachment #645218 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/288c6ff3dfd8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.