776480 - B2G RIL: missing handler for ipc message 'RIL:GetRadioState'

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

In 'RILContentHelper.js' we send a sync message 'RIL:GetRadioState' to request radio info. However, there is no corresponding handler for this ipc message.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> In 'RILContentHelper.js' we send a sync message 'RIL:GetRadioState' to
> request radio info. However, there is no corresponding handler for this ipc
> message.

Seems this is the regression of 762760? Maybe we should replace "RIL:GetRadioState" with "RIL:GetRilContext" ?

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> > In 'RILContentHelper.js' we send a sync message 'RIL:GetRadioState' to
> > request radio info. However, there is no corresponding handler for this ipc
> > message.
> 
> Seems this is the regression of bug 762760 ? Maybe we should replace
> "RIL:GetRadioState" with "RIL:GetRilContext" ?

Comment 3

[Philipp von Weitershausen [:philikon]]

Yes, good find. Can you fix? Thanks!

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll take it since it's my mistake.
Thanks for spotting this.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

rename IPC message "GetRadioState" to "GetRilContext" in RILContentHelper.js

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/288c6ff3dfd8

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/288c6ff3dfd8