Move InternalIsSupported to nsContentUtils

RESOLVED FIXED in mozilla19

Status

()

Core
DOM
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ayg, Assigned: Ms2ger)

Tracking

Trunk
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Updated

6 years ago
Assignee: nobody → Ms2ger
(Assignee)

Comment 1

6 years ago
Created attachment 667846 [details] [diff] [review]
Patch v1
Attachment #667846 - Flags: review?(khuey)
Comment on attachment 667846 [details] [diff] [review]
Patch v1

Review of attachment 667846 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsContentUtils.cpp
@@ +170,5 @@
>  #include "mozilla/Attributes.h"
>  #include "nsIParserService.h"
>  #include "nsIDOMScriptObjectFactory.h"
>  #include "nsSandboxFlags.h"
> +#include "nsSVGFeatures.h"

Can you stop including nsSVGFeatures.h in FragmentOrElement.cpp?

::: content/base/src/nsDOMAttribute.cpp
@@ +445,5 @@
>                              bool* aReturn)
>  {
>    OwnerDoc()->WarnOnceAbout(nsIDocument::eIsSupported);
>  
> +  *aReturn = nsContentUtils::InternalIsSupported(static_cast<nsIDOMAttr*>(this), 

Get rid of the trailing whitespace while you're here.
Attachment #667846 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 667846 [details] [diff] [review]
Patch v1

Review of attachment 667846 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/FragmentOrElement.cpp
@@ -112,5 @@
>  #include "mozAutoDocUpdate.h"
>  
>  #include "prprf.h"
>  #include "nsDOMMutationObserver.h"
> -#include "nsSVGFeatures.h"

Yeah, I believe I can
We might want to not land this immediately, to avoid bitrotting bug 773780.
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/d2f47ce40141
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.