Closed
Bug 776539
Opened 13 years ago
Closed 13 years ago
Move FormData to Paris bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file, 1 obsolete file)
|
23.94 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This doesn't build, because of workers.
Comment 1•13 years ago
|
||
What's the build failure, exactly?
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → Ms2ger
| Assignee | ||
Comment 2•13 years ago
|
||
Attachment #644929 -
Attachment is obsolete: true
Attachment #689701 -
Flags: review?(bzbarsky)
Comment 3•13 years ago
|
||
Comment on attachment 689701 [details] [diff] [review]
Patch v1
>+ "FormData interface constructor": true
Is there a bug covering this?
>+ // void append(DOMString name, Blob value, optional DOMString filename);
You might as well uncomment that and just have the implementation ignore the last arg, which is what would happen anyway right now, just in binding code. Would make it simpler to later update things to have it work.
r=me with that.
Attachment #689701 -
Flags: review?(bzbarsky) → review+
| Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 689701 [details] [diff] [review]
> Patch v1
>
> >+ "FormData interface constructor": true
>
> Is there a bug covering this?
Bug 793151, which I guess I should land.
Comment 5•13 years ago
|
||
Yes, please!
Comment 6•13 years ago
|
||
We should land this sooner rather than later, because until we do xhr send() is kinda broken if passed in a random object...
| Assignee | ||
Comment 7•13 years ago
|
||
Status: NEW → ASSIGNED
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•