The default bug view has changed. See this FAQ.

Move FormData to Paris bindings

RESOLVED FIXED in mozilla20

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 644929 [details] [diff] [review]
WIP

This doesn't build, because of workers.
What's the build failure, exactly?
(Assignee)

Updated

4 years ago
Assignee: nobody → Ms2ger
(Assignee)

Updated

4 years ago
Blocks: 819328
(Assignee)

Comment 2

4 years ago
Created attachment 689701 [details] [diff] [review]
Patch v1
Attachment #644929 - Attachment is obsolete: true
Attachment #689701 - Flags: review?(bzbarsky)
Comment on attachment 689701 [details] [diff] [review]
Patch v1

>+  "FormData interface constructor": true

Is there a bug covering this?

>+  // void append(DOMString name, Blob value, optional DOMString filename);

You might as well uncomment that and just have the implementation ignore the last arg, which is what would happen anyway right now, just in binding code.  Would make it simpler to later update things to have it work.

r=me with that.
Attachment #689701 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

4 years ago
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 689701 [details] [diff] [review]
> Patch v1
> 
> >+  "FormData interface constructor": true
> 
> Is there a bug covering this?

Bug 793151, which I guess I should land.
Yes, please!
We should land this sooner rather than later, because until we do xhr send() is kinda broken if passed in a random object...
(Assignee)

Comment 7

4 years ago
When bz asks...

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb469965c13
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/2fb469965c13
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.