Closed Bug 776556 Opened 9 years ago Closed 9 years ago

Code Signing breaks ASan OSX builds

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: decoder, Assigned: decoder)

Details

(Keywords: sec-want, Whiteboard: [asan][asan-build-blocker])

Attachments

(1 file, 1 obsolete file)

Since recently I'm hitting the following error with the ASan OSX try builds:

2012-07-23 03:38:15,611 - 9a0a3e00bc5221d486ea26cca848ec9f0c9279db: processing FirefoxNightlyDebug.app.tar.gz on https://mac-signing3.build.scl1.mozilla.com:9100
2012-07-23 03:38:15,811 - 9a0a3e00bc5221d486ea26cca848ec9f0c9279db: uploading for signing
2012-07-23 03:38:22,888 - 9a0a3e00bc5221d486ea26cca848ec9f0c9279db: error uploading file for signing: File too large


I guess this is due to ASan builds not being stripped, so I would suggest to disable signing builds that are built with --disable-install-strip. Patch is attached and seems to work but I'd prefer confirmation that this is a reasonable way to go and that the patch is actually doing the right thing :)
This can't quite be right, because our normal Mac nightlies also specify --disable-install-strip:
https://hg.mozilla.org/mozilla-central/file/9792ee3e5244/browser/config/mozconfigs/macosx-universal/nightly#l9

How big are ASan builds compared to normal Mac nightly builds?
Catlee suggested to just disable the signing when building with ASan, so I altered the patch to do exactly that.
Assignee: nobody → choller
Attachment #644944 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #646132 - Flags: review?(ted.mielczarek)
Comment on attachment 646132 [details] [diff] [review]
Disable package signing when ASan is enabled

Review of attachment 646132 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of hacky, but okay. Might be nice to have a --disable-codesigning configure option or something like that.
Attachment #646132 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/81478acd423f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.