Switch comm-central from using nsnull to nullptr.

RESOLVED FIXED in Thunderbird 17.0

Status

MailNews Core
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 17.0
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 645008 [details] [diff] [review]
comm-central: switch nsnull to nullptr

Bug 626472 is dropping nsnull in favour of nullptr.

I talked to Ehsan, and I think the plan is to land the definition of nullptr soon, and once it's available in mozilla-central, push our patch to try, and test building it using both clang and gcc.

I'll probably get our try server to apply the removal of nsnull against our mozilla-central subdirectory, for added assurance that we still build alright.
(Assignee)

Comment 1

5 years ago
Part 1 from Bug 626472 has landed in mozilla-central.

As per our plan, I'm going to push the Attachment 645008 [details] [diff] to try to see if we get green builds.
FWIW, nullptr is now on mozilla-central, so you guys can proceed with this whenever you want.
(Assignee)

Comment 3

5 years ago
Ok, here are our try results:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e3b12e72613a

Mostly green, but not perfect. The build failures on Windows seem to be unrelated. The bloattest crashes on Linux, and the crashes caused by Mozmill are more disturbing.

Cc'ing Irving, who's awesome at diagnosing crashes and stuff.

I'll start by poking at the Mozmill crashes.
(Assignee)

Comment 4

5 years ago
So the crashes on mailbloat seem to also be happening on trunk (sigh, they just showed up this morning), so that appears to be unrelated.
FWIW it will be really surprising if this results in crashes etc once you get green builds...
(Assignee)

Comment 6

5 years ago
Yeah, it turns out that other stuff landed on mozilla-central that broke us in new and wonderful ways.

I think we're getting close to sorting it all out. Anyhow, those reds on the try build can be safely ignored, and I think we're going to survive the landing.
(Assignee)

Comment 7

5 years ago
This spills outside of mailnews, and affects everything under comm-central.
Summary: Switch mailnews from using nsnull to nullptr. → Switch comm-central from using nsnull to nullptr.
(Assignee)

Comment 8

5 years ago
Created attachment 647163 [details] [diff] [review]
Switch nsnull to nullptr

Here's an up to date conversion patch
Attachment #645008 - Attachment is obsolete: true
Comment on attachment 647163 [details] [diff] [review]
Switch nsnull to nullptr

Review of attachment 647163 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp for calendar parts
Attachment #647163 - Flags: review+
(Assignee)

Comment 10

5 years ago
Mark:

My try build looks good (well, good enough, considering the current bustedness of the tree): https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=c2c1e3d40065

Fallen has confirmed that the Calendar bits look sane. I've leafed through the diff, and I don't see anything crazy. What's the protocol for a patch this big?

Should we get a swarm of people to ensure that this thing is OK, or should we just land it?

-Mike
On m-c, we just did sed -i 's/\bnsnull\b/nullptr/g' and ehsan gave me r+ for whatever that produced without manual review.  It's really unlikely this could cause problems, since nsnull is currently defined to be nullptr in m-c!
(Assignee)

Comment 12

5 years ago
Created attachment 648339 [details] [diff] [review]
Unbitrotted patch (checked in)

Re-ran sed script to un-bitrot, and committed to comm-central as

https://hg.mozilla.org/comm-central/rev/0a10c274a1fe
Attachment #647163 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.