776661 - silk_get_TOC doesn't zero out the entire silk_TOC_struct

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[(no longer active)]

/media/storage/moz/mozilla-inbound/media/libopus/silk/dec_API.c:360:39: warning: 'silk_memset' call operates on objects of type 'silk_TOC_struct' while the size is based on a
      different type 'silk_TOC_struct *' [-Wsizeof-pointer-memaccess]
    silk_memset( Silk_TOC, 0, sizeof( Silk_TOC ) );
                 ~~~~~~~~             ^~~~~~~~
/media/storage/moz/mozilla-inbound/media/libopus/silk/dec_API.c:360:39: note: did you mean to dereference the argument to 'sizeof' (and multiply it by the number of elements)?
    silk_memset( Silk_TOC, 0, sizeof( Silk_TOC ) );
                                      ^~~~~~~~
1 warning generated.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Ralph Giles (:rillian)]

Analysis by :derf from #developers on irc:

This doesn't affect our code; silk_get_TOC() is never called; it's left over code used by some other consumers of the SILK codec outside the opus tree.

If it were called, it's probably low risk, since it would zero at least the first field, and the other fields are initialized explicitly, assuming the caller uses nFramesPerPayload consistently.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 645035 [details] [diff] [review]
Patch (v1)

Fine with me, but please add it as an external patch file in the libopus directory and change update.sh to apply it.

Comment 4

[Ralph Giles (:rillian)]

Attachment: Patch (v2)

Updated to patch to conform to local style for maintaining differences from upstream. Carrying forward my own r+.

Comment 5

[(no longer active)]

I'll check this in shortly.  Thanks Ralph!

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8020aa862817

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8020aa862817

Comment 8

[Timothy B. Terriberry (:derf)]

This was committed upstream as http://git.xiph.org/?p=opus.git;a=commit;h=622046c1f1230e107664e35873d46b731f32df41