Last Comment Bug 776686 - Remove bogus include path from the Editor
: Remove bogus include path from the Editor
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jonathan Watt [:jwatt]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-23 13:26 PDT by Jonathan Watt [:jwatt]
Modified: 2012-07-26 14:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.02 KB, patch)
2012-07-23 13:40 PDT, Jonathan Watt [:jwatt]
ehsan: review+
Details | Diff | Review

Description Jonathan Watt [:jwatt] 2012-07-23 13:26:10 PDT
The path -I../../libeditor/base/src in editor/composer/src/Makefile.in does not exist. All it does is slow compilation by increasing the number of directories that are searched while resolving includes.
Comment 1 Jonathan Watt [:jwatt] 2012-07-23 13:40:50 PDT
Created attachment 645050 [details] [diff] [review]
patch
Comment 2 :Ehsan Akhgari (busy, don't ask for review please) 2012-07-23 13:44:02 PDT
Comment on attachment 645050 [details] [diff] [review]
patch

Nice!
Comment 4 Matt Brubeck (:mbrubeck) 2012-07-26 14:08:21 PDT
https://hg.mozilla.org/mozilla-central/rev/29874fe36f90

Note You need to log in before you can comment on or make changes to this bug.