FramebufferNativeWindow doesn't implement ANativeWindow::cancelBuffer

RESOLVED FIXED in mozilla17


7 years ago
8 months ago


(Reporter: marshall, Assigned: marshall)


Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)

On the emulator, When the b2g process tries to exit, a segfault happens when the emulator's EGL code tries to clean up it's internal buffers by calling eglCancelBuffer() -- unfortunately, ANativeWindow::cancelBuffer is not set by the FramebufferNativeWindow.

This is technically an AOSP bug, but we don't currently maintain forks of either platform_frameworks_base or platform_development (where this would be ideally fixed).

In the interest of maintainability, it is easy enough to set the cancelBuffer function pointer to a no-op so we can avoid segfaulting for now..
Posted patch cancelBuffer - v1 (obsolete) — Splinter Review
Attachment #645106 - Flags: review?(jones.chris.g)
I meant to say this happens in the EGL surface destructor. You can see the code in question here:

egl_window_surface_t destructor:

notice the missing set of cancelBuffer in FramebufferNativeWindow.cpp:
Comment on attachment 645106 [details] [diff] [review]
cancelBuffer - v1

>diff --git a/widget/gonk/nsWindow.cpp b/widget/gonk/nsWindow.cpp

>+/* static */ int
>+nsWindow::CancelBufferNoop(ANativeWindow* aWindow, ANativeWindowBuffer* aBuffer)

Let's just make this a static function in this compilation unit,
not part of nsWindow.

r=me with that change.
Attachment #645106 - Flags: review?(jones.chris.g) → review+
Looks like this is environment related -- this definitely compiles locally in the B2G emulator config. Phil mentioned that the Tinderboxes aren't currently setup for ICS: Bug 776045
No longer blocks: 764683
Attachment #645106 - Attachment is obsolete: true
I've confirmed this build error
Depends on: 776045
* I've confirmed this build error occurs because of the GB toolchain in Tinderbox. ICS based toolchains are building this patch just fine..
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17


8 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.