[b2g-bluetooth] Crash in bluetooth discovery due to initializer buried in NS_ASSERTION

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: qdot)

Tracking

Trunk
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When a DeviceFound message is handled by BluetoothDBusService.cpp's EventLoop function, the dbus iterator is wrapped in an NS_ASSERTION, meaning that it won't get called at all if it's being built in release. This causes very weird crashes.
Created attachment 645109 [details] [diff] [review]
Patch 1 (v1): Fix initializer creation to not be wrapped in NS_ASSERTION
Attachment #645109 - Flags: review?(mrbkap)
Attachment #645109 - Flags: review?(mrbkap) → review?(anygregor)
Attachment #645109 - Flags: review?(anygregor) → review+
FWIW, you can use MOZ_ASSERT_ALWAYS_TRUE for that. This is going to assert if the expression is false in debug build but will still run the expression in release builds.
http://hg.mozilla.org/integration/mozilla-inbound/rev/41a814f672cb
Target Milestone: --- → mozilla17

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/41a814f672cb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.