Closed Bug 776785 Opened 7 years ago Closed 7 years ago
Alarm API - hal::Set
Alarm takes |long|s, but should instead take PRInt32s
>+bool SetAlarm(long aSeconds, long aNanoseconds) These should both be PRInt32's, as far as I can tell. The only caller, AlarmHalService, has PRInt32s. We avoid raw types in Gecko code because the meaning of |long| is different on different platforms. (It's 64 bits wide on Linux 64, and 32 bits wide on Linux 32 and Windows 64.) Is there a good reason that these are long's? If not, we should fix it.
Summary: hal::SetAlarm takes |long|s, but should instead take PRInt32s → Alarm API - hal::SetAlarm takes |long|s, but should instead take PRInt32s
Ping on this bug. I can review the fix if you write the patch, Gene.
Thanks Justin! :) Sorry that I was busy with other issues. I'll come back with the patch today ASAP. Please stay tuned.
Hi Justin, Changes are trivial: replace the |long|s by |PRInt32|s. In addition to the hal:: functions, I also did the same thing for IDL for consistency. Please feel free to let me know if you didn't agree with these changes. Thanks for your reviews in advance :)
Attachment #647414 - Flags: review?(justin.lebar+bug)
Comment on attachment 647414 [details] [diff] [review] Patch Looks great; thanks! Do you need me to check this in for you?
Attachment #647414 - Flags: review?(justin.lebar+bug) → review+
(In reply to Justin Lebar [:jlebar] from comment #4) > Comment on attachment 647414 [details] [diff] [review] > Patch > > Looks great; thanks! > > Do you need me to check this in for you? Yes, thanks Justin! :) I don't have the privilege to check it in. Not yet pass the try sever (https://tbpl.mozilla.org/?tree=Try&rev=eb38577cd8d4) but I believe it works fine, since all the builds are successful and these changes won't affect the testing results. ;)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Note that we do use 'long' in IDL; the changes to IDL files in this bug were inappropriate.
(In reply to :Ms2ger (Back and backlogged) from comment #8) > Note that we do use 'long' in IDL; the changes to IDL files in this bug were > inappropriate. We also use PRInt32/PRUint32. Is that deprecated for some bizarre reason? $ git ls-files '*.idl' | xargs grep PRUint32 | wc -l 360 $ git ls-files '*.idl' | xargs grep PRInt32 | wc -l 102
You need to log in before you can comment on or make changes to this bug.