The default bug view has changed. See this FAQ.

Many Makefile's from dom/ missing from toolkit-makefiles.sh

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There are a number of Makefile's in dom/ missing from allmakefiles.sh.

Non-comprehensive list:

dom/interfaces/settings/Makefile
dom/apps/Makefile
dom/bindings/Makefile
dom/browser-element/Makefile
dom/devicestorage/Makefile
dom/contacts/Makefile
dom/media/Makefile
dom/settings/Makefile
dom/mms/Makefile
dom/identity/Makefile
dom/imptests/Makefile
dom/bindings/test/Makefile
(Assignee)

Comment 1

5 years ago
Errr - I guess there is some magic going on inside dom/. Possibly inherited from dom-config.mk? I have a feeling I shouldn't go down this rabbit hole...
allmakefiles.sh is a performance optimization.  Not being listed doesn't break anything, *unless* the directory omitted is a top-level directory (it's built from tier_*_dirs and not from DIRS or PARALLEL_DIRS).
Summary: Many Makefile's from dom/ missing from allmakefiles.sh → Many Makefile's from dom/ missing from toolkit-makefiles.sh
(Assignee)

Comment 3

5 years ago
Created attachment 646474 [details] [diff] [review]
Add missing Makefile's in dom/, v1

This avoid make-makefile in dom/ in my local build.

Try at http://tbpl.mozilla.org/?tree=Try&rev=5a42ea6ea663. Maybe. Try seems to be having issues.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #646474 - Flags: review?(khuey)
Comment on attachment 646474 [details] [diff] [review]
Add missing Makefile's in dom/, v1

Review of attachment 646474 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually look at this.  I assume you know what you're doing.
Attachment #646474 - Flags: review?(khuey) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/375d278adbd1
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/375d278adbd1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.