Closed Bug 776824 Opened 13 years ago Closed 13 years ago

Add isInBrowserElement to nsIPrincipal

Categories

(Core :: Security: CAPS, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17
blocking-basecamp +

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
extendedOrigin might be a bad idea for the moment. A lot of places seem to require access to some of the information "hidden" in the attribute. So let's make isInMozBrowserElement a real attribute and see what happens of extendedOrigin.
Attachment #645201 - Flags: superreview?(jonas)
Attachment #645201 - Flags: review?
Attachment #645201 - Flags: review? → review?(mrbkap)
blocking-basecamp: ? → +
Comment on attachment 645201 [details] [diff] [review] Patch This really feels like the wrong place to stick this. Extended origin makes sense, but to me principals are descriptions of privileges and asking a privilege if it's inside a browser element seems semantically wrong. Talking to jst, one thing he suggested is that we could tie principals to an "owner" that would then be able to return this sort of information. I'm clearing the request for now. If there is really no better place to stick this, I guess I'd be willing to r+ it, but I'd really rather search for an alternative first.
Attachment #645201 - Flags: review?(mrbkap)
Comment on attachment 645201 [details] [diff] [review] Patch After talking to Jonas, I'm OK with this. The name really threw me off though since it looks like we're asking a purely DOM question to a principal when we're actually asking "are you in this other security context."
Attachment #645201 - Flags: review+
Attached patch PatchSplinter Review
Jonas, could you sr that patch?
Attachment #645201 - Attachment is obsolete: true
Attachment #645201 - Flags: superreview?(jonas)
Attachment #646022 - Flags: superreview?(jonas)
Attachment #646022 - Flags: superreview?(jonas) → superreview+
Summary: Add isInMozBrowserElement to nsIPrincipal → Add isInBrowserElement to nsIPrincipal
Flags: in-testsuite+
Target Milestone: --- → mozilla17
Attachment #646022 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: