Last Comment Bug 776838 - Fix gstvideo detection when gstreamer is enabled and not in the default ld search path
: Fix gstvideo detection when gstreamer is enabled and not in the default ld se...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All OpenBSD
: -- normal (vote)
: mozilla17
Assigned To: Landry Breuil (:gaston)
:
Mentors:
Depends on: 422540
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-24 00:34 PDT by Landry Breuil (:gaston)
Modified: 2012-07-26 05:08 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add $GSTREAMER_LIBS to the gstvideo detection test (1.08 KB, patch)
2012-07-24 00:38 PDT, Landry Breuil (:gaston)
khuey: review+
Details | Diff | Review

Description Landry Breuil (:gaston) 2012-07-24 00:34:03 PDT
Atm, if passing --enable-gstreamer on OpenBSD the configure steps fails to detect gstvideo. The configure test passes -lgstvideo, but it's not in the default search path. We can reuse $GSTREAMER_LIBS which comes from pkg-config so that -L/usr/local/lib is passed to the test.
Comment 1 Landry Breuil (:gaston) 2012-07-24 00:38:42 PDT
Created attachment 645217 [details] [diff] [review]
Add $GSTREAMER_LIBS to the gstvideo detection test

Successful gstvideo detection with that patch. Another option would be to add a --with-gstreamer=/path option... but i'm not sure it's worth it.
Comment 2 cajbir (:cajbir) 2012-07-25 05:38:48 PDT
Comment on attachment 645217 [details] [diff] [review]
Add $GSTREAMER_LIBS to the gstvideo detection test

Looks good to me but needs to be reviewed by a build config peer. I've passed the review to one of them to cast their experienced eye over it.
Comment 4 Ed Morley [:emorley] 2012-07-26 05:08:22 PDT
https://hg.mozilla.org/mozilla-central/rev/1d3d70b31587

Note You need to log in before you can comment on or make changes to this bug.