Closed Bug 776838 Opened 8 years ago Closed 8 years ago

Fix gstvideo detection when gstreamer is enabled and not in the default ld search path

Categories

(Core :: Audio/Video, defect)

All
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: gaston, Assigned: gaston)

References

Details

Attachments

(1 file)

Atm, if passing --enable-gstreamer on OpenBSD the configure steps fails to detect gstvideo. The configure test passes -lgstvideo, but it's not in the default search path. We can reuse $GSTREAMER_LIBS which comes from pkg-config so that -L/usr/local/lib is passed to the test.
Depends on: 422540
Successful gstvideo detection with that patch. Another option would be to add a --with-gstreamer=/path option... but i'm not sure it's worth it.
Assignee: nobody → landry
Attachment #645217 - Flags: review?(chris.double)
Comment on attachment 645217 [details] [diff] [review]
Add $GSTREAMER_LIBS to the gstvideo detection test

Looks good to me but needs to be reviewed by a build config peer. I've passed the review to one of them to cast their experienced eye over it.
Attachment #645217 - Flags: review?(chris.double) → review?(khuey)
Keywords: checkin-needed
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/1d3d70b31587
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.