The default bug view has changed. See this FAQ.

Fix gstvideo detection when gstreamer is enabled and not in the default ld search path

RESOLVED FIXED in mozilla17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

Trunk
mozilla17
All
OpenBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Atm, if passing --enable-gstreamer on OpenBSD the configure steps fails to detect gstvideo. The configure test passes -lgstvideo, but it's not in the default search path. We can reuse $GSTREAMER_LIBS which comes from pkg-config so that -L/usr/local/lib is passed to the test.
(Assignee)

Updated

5 years ago
Depends on: 422540
(Assignee)

Comment 1

5 years ago
Created attachment 645217 [details] [diff] [review]
Add $GSTREAMER_LIBS to the gstvideo detection test

Successful gstvideo detection with that patch. Another option would be to add a --with-gstreamer=/path option... but i'm not sure it's worth it.
Assignee: nobody → landry
Attachment #645217 - Flags: review?(chris.double)

Comment 2

5 years ago
Comment on attachment 645217 [details] [diff] [review]
Add $GSTREAMER_LIBS to the gstvideo detection test

Looks good to me but needs to be reviewed by a build config peer. I've passed the review to one of them to cast their experienced eye over it.
Attachment #645217 - Flags: review?(chris.double) → review?(khuey)
Attachment #645217 - Flags: review?(khuey) → review+

Updated

5 years ago
Keywords: checkin-needed

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3d70b31587
Keywords: checkin-needed
Target Milestone: --- → mozilla17

Updated

5 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/1d3d70b31587
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.