Closed
Bug 776838
Opened 12 years ago
Closed 12 years ago
Fix gstvideo detection when gstreamer is enabled and not in the default ld search path
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: gaston, Assigned: gaston)
References
Details
Attachments
(1 file)
1.08 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Atm, if passing --enable-gstreamer on OpenBSD the configure steps fails to detect gstvideo. The configure test passes -lgstvideo, but it's not in the default search path. We can reuse $GSTREAMER_LIBS which comes from pkg-config so that -L/usr/local/lib is passed to the test.
Assignee | ||
Comment 1•12 years ago
|
||
Successful gstvideo detection with that patch. Another option would be to add a --with-gstreamer=/path option... but i'm not sure it's worth it.
Assignee: nobody → landry
Attachment #645217 -
Flags: review?(chris.double)
Comment 2•12 years ago
|
||
Comment on attachment 645217 [details] [diff] [review] Add $GSTREAMER_LIBS to the gstvideo detection test Looks good to me but needs to be reviewed by a build config peer. I've passed the review to one of them to cast their experienced eye over it.
Attachment #645217 -
Flags: review?(chris.double) → review?(khuey)
Attachment #645217 -
Flags: review?(khuey) → review+
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3d70b31587
Keywords: checkin-needed
Target Milestone: --- → mozilla17
Updated•12 years ago
|
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d3d70b31587
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•