Closed Bug 776872 Opened 12 years ago Closed 12 years ago

Remove calls to addVisit from the "bookmarks" folder

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file, 2 obsolete files)

This removes more addVisit calls in Places tests.
Attached patch The patch (obsolete) — Splinter Review
Easy changes here, though an indentation change makes the patch larger. In one
test, promises are used to wait for two asynchronous events regardless of the
order they are notified.
Attachment #645257 - Flags: feedback?(mak77)
Blocks: 700250
Attachment #645257 - Flags: feedback?(mak77) → feedback?(dteller)
Depends on: 776863
Blocks: 778694
Attached patch Updated patch (obsolete) — Splinter Review
Attachment #645257 - Attachment is obsolete: true
Attachment #683515 - Flags: review?(mak77)
Comment on attachment 683515 [details] [diff] [review]
Updated patch

Review of attachment 683515 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/bookmarks/test_async_observers.js
@@ +74,5 @@
>  PlacesUtils.bookmarks.addObserver(observer, false);
>  
> +add_task(function test_add_visit()
> +{
> +  let observerPromise = observer.reset();

Ok, so .reset looks like the wrong name now... maybe .prepare(), .setup(), or .init()?

::: toolkit/components/places/tests/bookmarks/test_nsINavBookmarkObserver.js
@@ +290,5 @@
>          { name: "guid", check: function (v) typeof(v) == "string" && /^[a-zA-Z0-9\-_]{12}$/.test(v) },
>          { name: "parentGuid", check: function (v) typeof(v) == "string" && /^[a-zA-Z0-9\-_]{12}$/.test(v) },
>        ] },
>    ];
> +  addVisits({ uri: uri, transition: TRANSITION_TYPED });

just use promiseAddvisits, I'd like to remove addVisits at a certain point, to have just one util
Attachment #683515 - Flags: review?(mak77) → review+
Attached patch Revised patchSplinter Review
Attachment #683515 - Attachment is obsolete: true
Attachment #687069 - Flags: feedback?(mak77)
Attachment #687069 - Flags: feedback?(mak77) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/139a9d5cc4d3
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/139a9d5cc4d3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: