Closed Bug 776898 Opened 11 years ago Closed 11 years ago

PluginInstanceParent nullptr related build error with vc11

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: jimm, Unassigned)

References

Details

Attachments

(1 file)

patch
817 bytes, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
PluginInstanceParent.cpp
f:\mozilla\firefox\mcvc11-dbg\dist\include\gfxFont.h(2058) : warning C4244: 'return' : conversion from 'double' to 'float', possible loss of data
f:/Mozilla/firefox/mc/dom/plugins/ipc/PluginInstanceParent.cpp(1925) : error C2440: '=' : cannot convert from 'nullptr' to 'uint64_t'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
make[4]: *** [PluginInstanceParent.obj] Error 2
make[4]: Leaving directory `/F/Mozilla/firefox/MCVC11-DBG/dom/plugins/ipc'
Attached patch patch — — Splinter Review 

    
  

        Attachment #645275 -
        Flags: review?(ehsan)

    
  

        Attachment #645275 -
        Flags: review?(ehsan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0548c5e7a003
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.