Last Comment Bug 776914 - nsProfileLock nullptr related build errors with vc11
: nsProfileLock nullptr related build errors with vc11
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: 626472 VC11
  Show dependency treegraph
 
Reported: 2012-07-24 07:27 PDT by Jim Mathies [:jimm]
Modified: 2012-07-26 05:13 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.12 KB, patch)
2012-07-24 07:29 PDT, Jim Mathies [:jimm]
netzen: review+
Details | Diff | Splinter Review

Description Jim Mathies [:jimm] 2012-07-24 07:27:31 PDT
nsProfileLock.cpp
f:/Mozilla/firefox/mc/profile/dirserviceprovider/src/nsProfileLock.cpp(583) : error C2664: 'CreateFileW' : cannot convert parameter 6 from 'nullptr' to 'DWORD'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
make[5]: *** [nsProfileLock.obj] Error 2

all most there....
Comment 1 Jim Mathies [:jimm] 2012-07-24 07:29:56 PDT
Created attachment 645295 [details] [diff] [review]
patch
Comment 2 Jim Mathies [:jimm] 2012-07-24 07:32:51 PDT
Actually, that last param can stay an nsnull, in bug 626472 these will be mass changed to nullptr.
Comment 3 Brian R. Bondy [:bbondy] 2012-07-24 07:42:07 PDT
I'm fine either way, the important one is the DWORD value
Comment 4 Ed Morley [:emorley] 2012-07-26 05:13:31 PDT
https://hg.mozilla.org/mozilla-central/rev/e3b75fdcdbf3

Note You need to log in before you can comment on or make changes to this bug.