The rest of the nullptr related build errors with vc11

RESOLVED FIXED in mozilla17

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Unassigned)

Tracking

Trunk
mozilla17
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
no need to keep filing new bugs, these are all smallish changes.
(Reporter)

Comment 1

5 years ago
nsParentalControlsServiceWin.cpp
f:/Mozilla/firefox/mc/toolkit/components/parentalcontrols/nsParentalControlsServiceWin.cpp(47) : error C2440: 'initializing' : cannot convert from 'nullptr' to 'REGHANDLE'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/mc/toolkit/components/parentalcontrols/nsParentalControlsServiceWin.cpp(47) : error C2439: 'nsParentalControlsServiceWin::mProvider' : member could not be initialized
        f:\mozilla\firefox\mc\toolkit\components\parentalcontrols\nsParentalControlsServiceWin.h(34) : see declaration of 'nsParentalControlsServiceWin::mProvider'
make[5]: *** [nsParentalControlsServiceWin.obj] Error 2
(Reporter)

Comment 2

5 years ago
dlldeps-xul.cpp
f:/Mozilla/firefox/mc/toolkit/library/dlldeps-xul.cpp(9) : error C2664: 'XRE_main' : cannot convert parameter 4 from 'nullptr' to 'PRUint32'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
make[1]: *** [dlldeps-xul.obj] Error 2
(Reporter)

Comment 3

5 years ago
Created attachment 645306 [details] [diff] [review]
patch

The parental controls one is obvious. The XRE-main one is actually a bug from the metro work, that should have been zero since it's a flag, not a ptr.
Attachment #645306 - Flags: review?(netzen)
Attachment #645306 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/fe77957061ea
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.