776918 - The rest of the nullptr related build errors with vc11

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jim Mathies [:jimm]]

no need to keep filing new bugs, these are all smallish changes.

Comment 1

[Jim Mathies [:jimm]]

nsParentalControlsServiceWin.cpp
f:/Mozilla/firefox/mc/toolkit/components/parentalcontrols/nsParentalControlsServiceWin.cpp(47) : error C2440: 'initializing' : cannot convert from 'nullptr' to 'REGHANDLE'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
f:/Mozilla/firefox/mc/toolkit/components/parentalcontrols/nsParentalControlsServiceWin.cpp(47) : error C2439: 'nsParentalControlsServiceWin::mProvider' : member could not be initialized
        f:\mozilla\firefox\mc\toolkit\components\parentalcontrols\nsParentalControlsServiceWin.h(34) : see declaration of 'nsParentalControlsServiceWin::mProvider'
make[5]: *** [nsParentalControlsServiceWin.obj] Error 2

Comment 2

[Jim Mathies [:jimm]]

dlldeps-xul.cpp
f:/Mozilla/firefox/mc/toolkit/library/dlldeps-xul.cpp(9) : error C2664: 'XRE_main' : cannot convert parameter 4 from 'nullptr' to 'PRUint32'
        A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
make[1]: *** [dlldeps-xul.obj] Error 2

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

The parental controls one is obvious. The XRE-main one is actually a bug from the metro work, that should have been zero since it's a flag, not a ptr.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fe77957061ea