Closed
Bug 777032
Opened 12 years ago
Closed 12 years ago
use timeBeginPeriod when needed to do high resolution profiling
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jrmuizel, Unassigned)
Details
(Whiteboard: [snappy])
Attachments
(1 file)
885 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The default sleep time on windows is 15.6ms. This is insufficient for our profiling needs.
Reporter | ||
Updated•12 years ago
|
Whiteboard: [snappy]
Comment 2•12 years ago
|
||
Comment on attachment 645752 [details] [diff] [review] Use timeBeginPeriod when necessary (I hate the :: prefix... It would be good if you can take it out!)
Attachment #645752 -
Flags: review?(ehsan) → review+
Comment 3•12 years ago
|
||
I hated it at first but it's the style we use in cocoa to say we're calling into OS library.
Comment 4•12 years ago
|
||
(In reply to comment #3) > I hated it at first but it's the style we use in cocoa to say we're calling > into OS library. And why did you stop hating it? I find it distracting, it's like using |this->| to access members...
Comment 5•12 years ago
|
||
It's easy to know if you're calling something in Gecko or the OS that isn't cross platform. It's similar to using sStaticVar, give you a bit of info.
Comment 6•12 years ago
|
||
(In reply to comment #5) > It's easy to know if you're calling something in Gecko or the OS that isn't > cross platform. It's similar to using sStaticVar, give you a bit of info. OK, I'm fine with it either way, but note that a :: prefix only shows that you're calling something from the global scope. It could be Gecko, libc, OS function, etc.
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8ed3f453a114
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•