777032 - use timeBeginPeriod when needed to do high resolution profiling

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The default sleep time on windows is 15.6ms. This is insufficient for our profiling needs.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use timeBeginPeriod when necessary

Comment 2

[(no longer active)]

Comment on attachment 645752 [details] [diff] [review]
Use timeBeginPeriod when necessary

(I hate the :: prefix... It would be good if you can take it out!)

Comment 3

[Benoit Girard (:BenWa)]

I hated it at first but it's the style we use in cocoa to say we're calling into OS library.

Comment 4

[(no longer active)]

(In reply to comment #3)
> I hated it at first but it's the style we use in cocoa to say we're calling
> into OS library.

And why did you stop hating it?  I find it distracting, it's like using |this->| to access members...

Comment 5

[Benoit Girard (:BenWa)]

It's easy to know if you're calling something in Gecko or the OS that isn't cross platform. It's similar to using sStaticVar, give you a bit of info.

Comment 6

[(no longer active)]

(In reply to comment #5)
> It's easy to know if you're calling something in Gecko or the OS that isn't
> cross platform. It's similar to using sStaticVar, give you a bit of info.

OK, I'm fine with it either way, but note that a :: prefix only shows that you're calling something from the global scope.  It could be Gecko, libc, OS function, etc.

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/8ed3f453a114