777084 - stop returning arrays from DeviceStorage.getDeviceStorage()

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

Passing arrays back from:

 getDeviceStorage(DOMString type);

sounded like it was the right thing to do, but it isn't.  Instead we should have different 'types' for shared directories (like "sharedpictures") or something.

Currently we don't even support anything other than returning one DeviceStorage anyhow.

Lets restore DeviceStorage to what we had.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 645511 [details] [diff] [review]
patch v.1

Review of attachment 645511 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +1412,4 @@
>  {
> +  nsRefPtr<nsDOMDeviceStorage> storage = new nsDOMDeviceStorage();
> +  if (NS_SUCCEEDED(storage->Init(aWin, aType))) {
> +    NS_ADDREF(*aStore = storage);

Nit: |storage.forget(aStore)| should work.

::: dom/interfaces/devicestorage/nsIDOMNavigatorDeviceStorage.idl
@@ +7,5 @@
>  
>  /**
>   * Property that extends the navigator object.
>   */
>  [scriptable, uuid(A4B2831D-6065-472F-8A6D-2C9085C74C15)]

Need to bump the IID

Comment 2

[Doug Turner (:dougt)]

> Nit: |storage.forget(aStore)| should work.


Everywhere in this file we use the macros NS_ADDREF or NS_IF_ADDREF.  Maybe as a follow up we can convert these all over to something more modern?

> Need to bump the IID

Thanks!

Comment 3

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb017d051029

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cb017d051029