777191 - Fix warning about uninitialized variable in DefineIDBInterfaceConstants()

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-uninitialized-interface-warning.patch

mozilla/central/dom/base/nsDOMClassInfo.cpp: In function 'nsresult DefineIDBInterfaceConstants(JSContext*, JSObject*, const nsIID*)':
mozilla/central/dom/base/nsDOMClassInfo.cpp:6013: warning: 'interface' may be used uninitialized in this function

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Does that actually fix the warning?  Is GCC smart enough to realize that MOZ_NOT_REACHED doesn't return?  What about in opt builds?

Comment 2

[Chris Peterson [:cpeterson]]

This patch fixes the warning for my local --enable-optimize build.

MOZ_NOT_REACHED is not a nop in opt builds. It calls __builtin_unreachable() or abort(), depending on your compiler.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ah, it's different than NS_NOTREACHED then.

/me grumbles about having all these different things.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 645610 [details] [diff] [review]
fix-uninitialized-interface-warning.patch

Review of attachment 645610 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.cpp
@@ +6005,5 @@
>      interface = IDBConstant::IDBRequest;
>    }
>    else if (aIID->Equals(NS_GET_IID(nsIIDBTransaction))) {
>      interface = IDBConstant::IDBTransaction;
> +  } else {

}
else {

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff0749529a6

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6ff0749529a6