Temporarily disable slow SQL reporting

RESOLVED FIXED in Firefox 15

Status

()

Toolkit
Telemetry
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vladan, Assigned: vladan)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(firefox14- wontfix, firefox15+ fixed, firefox16+ fixed, firefox17 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In bug 776469, we found out that prepared SQL strings reported by Telemetry sometimes contain URLs. We want to temporarily suspend slow SQL reporting until a patch that sanitizes SQL strings is ready.
(Assignee)

Comment 1

5 years ago
Created attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js
Assignee: nobody → vdjeric
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #645634 - Flags: review?(taras.mozilla)
Attachment #645634 - Flags: review?(taras.mozilla) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js

[Approval Request Comment]
Regression caused by (bug #): 699051
User impact if declined: Users using certain addons may end up submitting private data to Telemetry
Testing completed (on m-c, etc.): Trivial petch, tested on mozilla-inbound
Risk to taking this patch (and alternatives if risky): No risk foreseen. Hypothetically speaking, perhaps it might interfere with Telemetry reporting if merged incorrectly
String or UUID changes made by this patch: None
Attachment #645634 - Flags: approval-mozilla-release?
Attachment #645634 - Flags: approval-mozilla-beta?
Attachment #645634 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 3

5 years ago
Comment on attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae6b9545a0f4
Attachment #645634 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/ae6b9545a0f4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox17: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Setting tracking flags based on branches requested in comment 2.

I don't normally set these when merging (other than marking the m-c branch as fixed), so please make sure to do this another time so things don't accidentally get overlooked once the bug is resolved fixed post merge :-)
status-firefox14: --- → affected
status-firefox15: --- → affected
status-firefox16: --- → affected
tracking-firefox14: --- → ?
tracking-firefox15: --- → ?
tracking-firefox16: --- → ?

Updated

5 years ago
status-firefox14: affected → wontfix
tracking-firefox14: ? → -
tracking-firefox15: ? → +
tracking-firefox16: ? → +
Group: mozilla-corporation-confidential

Comment 6

5 years ago
Comment on attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js

[Triage Comment]
Approved for Aurora/Beta.
Attachment #645634 - Flags: approval-mozilla-release?
Attachment #645634 - Flags: approval-mozilla-release-
Attachment #645634 - Flags: approval-mozilla-beta?
Attachment #645634 - Flags: approval-mozilla-beta+
Attachment #645634 - Flags: approval-mozilla-aurora?
Attachment #645634 - Flags: approval-mozilla-aurora+
To follow-up on the release-, given that we're implementing a server side solution to filter this data, I think we can rely on that instead of pushing for a ride along in any potential chemspill - and, afaik, there is nothing that currently warrants a chemspill with which to ride along.
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/90fce5a844d0
https://hg.mozilla.org/releases/mozilla-beta/rev/28c2cb14a1e4

Updated

5 years ago
status-firefox15: affected → fixed
status-firefox16: affected → fixed
Is there something QA can do to verify this fix?
Whiteboard: [qa?]
(Assignee)

Comment 10

5 years ago
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #9)
> Is there something QA can do to verify this fix?

No, in fact, bug 779310 undid this change. I think only the release channel still has slowSQL turned off
Whiteboard: [qa?]
Okay, thanks Vladan.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.