777220 - Temporarily disable slow SQL reporting

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

In bug 776469, we found out that prepared SQL strings reported by Telemetry sometimes contain URLs. We want to temporarily suspend slow SQL reporting until a patch that sanitizes SQL strings is ready.

Comment 1

[Vladan Djeric (:vladan)]

Attachment: Don't fetch slow sql in TelemetryPing.js

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js

[Approval Request Comment]
Regression caused by (bug #): 699051
User impact if declined: Users using certain addons may end up submitting private data to Telemetry
Testing completed (on m-c, etc.): Trivial petch, tested on mozilla-inbound
Risk to taking this patch (and alternatives if risky): No risk foreseen. Hypothetically speaking, perhaps it might interfere with Telemetry reporting if merged incorrectly
String or UUID changes made by this patch: None

Comment 3

[Vladan Djeric (:vladan)]

Comment on attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae6b9545a0f4

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ae6b9545a0f4

Comment 5

[Ed Morley [:emorley]]

Setting tracking flags based on branches requested in comment 2.

I don't normally set these when merging (other than marking the m-c branch as fixed), so please make sure to do this another time so things don't accidentally get overlooked once the bug is resolved fixed post merge :-)

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 645634 [details] [diff] [review]
Don't fetch slow sql in TelemetryPing.js

[Triage Comment]
Approved for Aurora/Beta.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

To follow-up on the release-, given that we're implementing a server side solution to filter this data, I think we can rely on that instead of pushing for a ride along in any potential chemspill - and, afaik, there is nothing that currently warrants a chemspill with which to ride along.

Comment 8

[Vladan Djeric (:vladan)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/90fce5a844d0
https://hg.mozilla.org/releases/mozilla-beta/rev/28c2cb14a1e4

Comment 9

[u279076]

Is there something QA can do to verify this fix?

Comment 10

[Vladan Djeric (:vladan)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #9)
> Is there something QA can do to verify this fix?

No, in fact, bug 779310 undid this change. I think only the release channel still has slowSQL turned off

Comment 11

[u279076]

Okay, thanks Vladan.