77723 - Nested DL elements not always indenting

Status: VERIFIED DUPLICATE of bug 8749

(Core :: DOM: HTML Parser, enhancement, P5)

Description

[[e-mail]]

In build 2001031008 the page given loads correctly. However in build 2001042404
none of the nested lists are indented.

Comment 1

[Johnny Stenback (:jst)]

Not a DOM problem, over to parser for futher investigation.

Comment 2

[Fabian Guisset]

I can confirm this on win2k build 2001042504... the easiest way to reproduce is
to load the bookmarks.html file in the browser.
Updating severity to major because... well it's a tag that doesn't work ;)

Comment 3

[harishd]

Looks bad. Setting to m0.9.1.

Comment 4

[harishd]

Attachment: Test case

Comment 5

[harishd]

Content Model:

docshell=00FEF060
html@01009860 refcount=7<
  head@01009770 refcount=2<
  >
  Text@03175200 refcount=3<\n>
  body@0317EDE0 refcount=3<
    Text@037842C0 refcount=3<\n>
    dl@03784210 style=border-top-width: medium; border-top-style: ridge; border-
top-color: red; border-right-width: medium; border-right-style: ridge; border-ri
ght-color: red; border-bottom-width: medium; border-bottom-style: ridge; border-
bottom-color: red; border-left-width: medium; border-left-style: ridge; border-l
eft-color: red;  refcount=3<
      dt@03780EC0 refcount=3<
        Text@03780E50 refcount=3<\n  >
        dl@03780DF0 refcount=3<
          dt@03780D90 refcount=3<
            Text@03780D20 refcount=3<\n     indent\n>
          >
        >
      >
    >
  >
>

Comment 6

[harishd]

It looks like the parser is doing the correct thing. Over to layout for analysis.

-->attinasi.

Comment 7

[Marc Attinasi]

Interesting: I created a slightly different testcase that shows that the
indentation of nested DL's works if there is a DD in there, even if empty. I'll
attach it for those who are interested. CC'd rick as we discussed this briefly.

Comment 8

[Marc Attinasi]

Attachment: Testcase: has nested DL with no DD and netsted DL with empty DD

Comment 9

[Marc Attinasi]

I think the problem is this rule that was removed from html.css by Ian back in
Sept of 2000 as part of a restructiring:

dl dl {                                                                         
 margin: 0 0 0 40px;                                                           
} 

Putting this into the testcase make the nested <DT> with not <DD> indent as I
believe the reporter expects.

CC'ing Ian to see if he remembers why that was removed...

Comment 10

[Marc Attinasi]

I'm changint the summary and downgrading this slightly because I do not think
that Definition Lists have really stopped working. Using DL /DT to get indenting
may have regressed, but the 'normal' use of DL / DT / DD to create definition
lists has not broken. It is still a bug, but not as critical as originally
reported. That said, it looks like an easy fix too.

Comment 11

[Hixie (not reading bugmail)]

If we put it back it should go in quirks.css.

Comment 12

[Marc Attinasi]

OK, so, is it even a bug? Nav 4.7 does not indent the testcase the way the
author expects, but IE does, so by my seat-of-the-pants analysis I'd say this is
not even a qurik worth handling. I cannot tell, but since the rule used to be
there, and was eliminated when the agent css files were celaned up, I thought it
was worth considering.

Comment 13

[Hixie (not reading bugmail)]

The spec leaves it undefined. I can't really comment on whether we want to
follow Win IE or Nav 4 or Opera or Mac IE or Lynx or Konqueror as far as our
response to invalid markup goes; I have no opinion and at this point I think
we have bigger fish to fry... :-)

Comment 14

[[e-mail]]

OK I've fixed the page to validate to HTML 4.01 Transitional so you can resolve
this as invalid or wontfix or whatever.

Comment 15

[Marc Attinasi]

Thanks Neil, I'll mark it WONTFIX because it is a bug, just not one we want to
deal with at this time (emulating Quirks is tough business).

Comment 16

[bsharma]

Marking verified as per above developer comments.

Comment 17

[[e-mail]]

I've found out where I originally saw that indentation style.

It was a product called Netscape Composer 4.x

If you use it to indent a dd or a dt it just wraps an extra dl around it.

So I've reopened it but as a future enhancement to quirks.css

Comment 18

[Marc Attinasi]

Part of this was fixed with the patch for bug 8749 - closing as a dup.

*** This bug has been marked as a duplicate of 8749 ***

Comment 19

[[e-mail]]

vrfy dup