Closed
Bug 777278
Opened 13 years ago
Closed 13 years ago
Implement nsIDOMStorageEvent using event implementation codegen
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(2 files)
|
14.33 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
|
14.28 KB,
patch
|
Details | Diff | Splinter Review |
patch coming
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #645692 -
Flags: review?(honzab.moz)
|
||
Comment 2•13 years ago
|
||
There is NS_NewDOMStorageEvent function used, but it is not defined in the patch either is not in mxr. I presume there is some dependency that needs to land prior this patch. Could you please add that dep to the list? Thanks.
|
||
Comment 3•13 years ago
|
||
No, the function will be generated by the codegen in js/xpconnect/src.
|
|
||
Comment 4•13 years ago
|
||
(In reply to :Ms2ger from comment #3)
> No, the function will be generated by the codegen in js/xpconnect/src.
OK, can I know how that works?
|
|
Assignee | |
Comment 5•13 years ago
|
||
See bug 765163. It has example .h and .cpp
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 645692 [details] [diff] [review]
patch
Review of attachment 645692 [details] [diff] [review]:
-----------------------------------------------------------------
r=honzab.
Attachment #645692 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
|
Assignee | |
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•