Last Comment Bug 777278 - Implement nsIDOMStorageEvent using event implementation codegen
: Implement nsIDOMStorageEvent using event implementation codegen
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (high review load, please consider other reviewers)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 02:59 PDT by Olli Pettay [:smaug] (high review load, please consider other reviewers)
Modified: 2012-08-01 09:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (14.33 KB, patch)
2012-07-25 03:28 PDT, Olli Pettay [:smaug] (high review load, please consider other reviewers)
honzab.moz: review+
Details | Diff | Review
up-to-date (14.28 KB, patch)
2012-08-01 09:16 PDT, Olli Pettay [:smaug] (high review load, please consider other reviewers)
no flags Details | Diff | Review

Description Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-07-25 02:59:07 PDT
patch coming
Comment 1 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-07-25 03:28:01 PDT
Created attachment 645692 [details] [diff] [review]
patch
Comment 2 Honza Bambas (:mayhemer) 2012-07-25 06:41:53 PDT
There is NS_NewDOMStorageEvent function used, but it is not defined in the patch either is not in mxr.  I presume there is some dependency that needs to land prior this patch.  Could you please add that dep to the list?  Thanks.
Comment 3 :Ms2ger 2012-07-25 06:46:02 PDT
No, the function will be generated by the codegen in js/xpconnect/src.
Comment 4 Honza Bambas (:mayhemer) 2012-07-25 06:48:48 PDT
(In reply to :Ms2ger from comment #3)
> No, the function will be generated by the codegen in js/xpconnect/src.

OK, can I know how that works?
Comment 5 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-07-25 06:54:15 PDT
See bug 765163. It has example .h and .cpp
Comment 6 Honza Bambas (:mayhemer) 2012-08-01 05:22:03 PDT
Comment on attachment 645692 [details] [diff] [review]
patch

Review of attachment 645692 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab.
Comment 7 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-08-01 09:16:12 PDT
Created attachment 647978 [details] [diff] [review]
up-to-date
Comment 8 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-08-01 09:47:42 PDT
https://hg.mozilla.org/mozilla-central/rev/476a189f5cda

Note You need to log in before you can comment on or make changes to this bug.