Last Comment Bug 777284 - B2G 3G: Sometimes toggling off data call failed
: B2G 3G: Sometimes toggling off data call failed
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla17
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on:
Blocks: b2g-3g
  Show dependency treegraph
 
Reported: 2012-07-25 03:18 PDT by Shian-Yow Wu [:swu]
Modified: 2012-07-31 13:55 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
?
+


Attachments
Log for toggling off 3G data call failure (17.70 KB, text/plain)
2012-07-25 03:18 PDT, Shian-Yow Wu [:swu]
no flags Details
Fix deactivateDataCall failure (979 bytes, patch)
2012-07-26 03:24 PDT, Shian-Yow Wu [:swu]
philipp: review+
Details | Diff | Splinter Review

Description Shian-Yow Wu [:swu] 2012-07-25 03:18:09 PDT
Created attachment 645689 [details]
Log for toggling off 3G data call failure

This happens on Otoro phone, I didn't test on other devices.
Sometimes toggling off data call failed.  When it happens, the rmnet0 interface still showing up.
Comment 1 José Antonio Olivera Ortega [:jaoo] 2012-07-25 03:30:31 PDT
Please, could you also attach the output of |adb shell netcfg| command after toggling off the data call?
Comment 2 Shian-Yow Wu [:swu] 2012-07-25 03:42:21 PDT
Yes, it's here.  When this happens, options.cid was not passed to REQUEST_DEACTIVATE_DATA_CALL() in ril_work.js.

root@android:/ # netcfg                                                        
lo       UP                                   127.0.0.1/8   0x00000049 00:00:00:00:00:00
rmnet0   UP                                 10.51.20.80/30  0x00000041 00:00:00:00:00:00
rmnet1   DOWN                                   0.0.0.0/0   0x00000000 00:00:00:00:00:00
rmnet2   DOWN                                   0.0.0.0/0   0x00000000 00:00:00:00:00:00
rmnet3   DOWN                                   0.0.0.0/0   0x00001002 a6:01:d1:a8:10:45
rmnet4   DOWN                                   0.0.0.0/0   0x00001002 36:98:92:54:5b:7e
rmnet5   DOWN                                   0.0.0.0/0   0x00001002 ce:9a:eb:9f:6d:89
rmnet6   DOWN                                   0.0.0.0/0   0x00001002 9a:96:7c:2a:51:1e
rmnet7   DOWN                                   0.0.0.0/0   0x00001002 3e:dd:a9:d3:22:a3
tunl0    DOWN                                   0.0.0.0/0   0x00000080 00:00:00:00:00:00
sit0     DOWN                                   0.0.0.0/0   0x00000080 00:00:00:00:00:00
ip6tnl0  DOWN                                   0.0.0.0/0   0x00000080 00:00:00:00:00:00
wlan0    UP                               10.247.37.238/21  0x00001043 84:74:2a:f1:52:c1
Comment 3 José Antonio Olivera Ortega [:jaoo] 2012-07-25 03:50:27 PDT
Could you test this change at this line [1]?

-    let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL);
+    let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL, options);

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#1839
Comment 4 Shian-Yow Wu [:swu] 2012-07-25 18:44:12 PDT
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Could you test this change at this line [1]?
> 
> -    let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL);
> +    let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL, options);

Yes, it worked.  Thank you!
Would you like to submit a patch?
Comment 5 Shian-Yow Wu [:swu] 2012-07-25 18:49:12 PDT
clee, the blocking-basecamp flag changed to '?' automatically after sending previous comment, and I cannot changed it back to + again.  Can you change it back?
Comment 6 José Antonio Olivera Ortega [:jaoo] 2012-07-25 23:41:23 PDT
(In reply to Shian-Yow Wu from comment #4)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Would you like to submit a patch?

I also have that change in a patch in my queue but I would need to clean it a bit. If you already have a patch and you test it please go ahead!
Comment 7 Shian-Yow Wu [:swu] 2012-07-26 03:24:36 PDT
Created attachment 646078 [details] [diff] [review]
Fix deactivateDataCall failure

I've tested it worked on otoro phone.
Comment 8 Yoshi Huang[:allstars.chh] (OOO ~ 9.30) 2012-07-26 19:57:01 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/b57cd49148d0

Note You need to log in before you can comment on or make changes to this bug.