Created attachment 645689 [details]
Log for toggling off 3G data call failure
This happens on Otoro phone, I didn't test on other devices.
Sometimes toggling off data call failed. When it happens, the rmnet0 interface still showing up.
Please, could you also attach the output of |adb shell netcfg| command after toggling off the data call?
Yes, it's here. When this happens, options.cid was not passed to REQUEST_DEACTIVATE_DATA_CALL() in ril_work.js.
root@android:/ # netcfg
lo UP 127.0.0.1/8 0x00000049 00:00:00:00:00:00
rmnet0 UP 10.51.20.80/30 0x00000041 00:00:00:00:00:00
rmnet1 DOWN 0.0.0.0/0 0x00000000 00:00:00:00:00:00
rmnet2 DOWN 0.0.0.0/0 0x00000000 00:00:00:00:00:00
rmnet3 DOWN 0.0.0.0/0 0x00001002 a6:01:d1:a8:10:45
rmnet4 DOWN 0.0.0.0/0 0x00001002 36:98:92:54:5b:7e
rmnet5 DOWN 0.0.0.0/0 0x00001002 ce:9a:eb:9f:6d:89
rmnet6 DOWN 0.0.0.0/0 0x00001002 9a:96:7c:2a:51:1e
rmnet7 DOWN 0.0.0.0/0 0x00001002 3e:dd:a9:d3:22:a3
tunl0 DOWN 0.0.0.0/0 0x00000080 00:00:00:00:00:00
sit0 DOWN 0.0.0.0/0 0x00000080 00:00:00:00:00:00
ip6tnl0 DOWN 0.0.0.0/0 0x00000080 00:00:00:00:00:00
wlan0 UP 10.247.37.238/21 0x00001043 84:74:2a:f1:52:c1
Could you test this change at this line ?
- let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL);
+ let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL, options);
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Could you test this change at this line ?
> - let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL);
> + let token = Buf.newParcel(REQUEST_DEACTIVATE_DATA_CALL, options);
Yes, it worked. Thank you!
Would you like to submit a patch?
clee, the blocking-basecamp flag changed to '?' automatically after sending previous comment, and I cannot changed it back to + again. Can you change it back?
(In reply to Shian-Yow Wu from comment #4)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Would you like to submit a patch?
I also have that change in a patch in my queue but I would need to clean it a bit. If you already have a patch and you test it please go ahead!
Created attachment 646078 [details] [diff] [review]
Fix deactivateDataCall failure
I've tested it worked on otoro phone.