Closed
Bug 777293
Opened 13 years ago
Closed 13 years ago
Remove NS_NewCSSStyleSheet
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
6.82 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #645698 -
Flags: review?(dbaron)
Comment on attachment 645698 [details] [diff] [review]
Patch v1
>-nsresult
>-NS_NewCSSStyleSheet(nsCSSStyleSheet** aInstancePtrResult)
>-{
>- *aInstancePtrResult = nsnull;
>- nsCSSStyleSheet *it = new nsCSSStyleSheet();
>-
>- if (!it) {
>- return NS_ERROR_OUT_OF_MEMORY;
>- }
>-
>- NS_ADDREF(it);
>-
>- if (!it->mInner || !it->mInner->mPrincipal) {
>- NS_RELEASE(it);
>- return NS_ERROR_OUT_OF_MEMORY;
>- }
>-
>- *aInstancePtrResult = it;
>- return NS_OK;
>-}
Because of the it->mInner->mPrincipal check here, you need to change nsCSSStyleSheetInner::nsCSSStyleSheetInner to NS_RUNTIMEABORT if mPrincipal is null after the do_CreateInstance call.
r=dbaron with that
Attachment #645698 -
Flags: review?(dbaron) → review+
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → Ms2ger
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
|
||
Comment 3•13 years ago
|
||
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 4•13 years ago
|
||
Flags: in-testsuite-
|
|
||
Comment 5•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•