Tab curve is low resolution on ~170DPI

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
Theme and Visual Design
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: sriram)

Tracking

({polish, uiwanted})

15 Branch
Firefox 17
ARM
Android
polish, uiwanted
Points:
---

Firefox Tracking Flags

(firefox15 fixed, firefox16 verified, firefox17 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Galaxy Tab 2 7", 1024x600 ~170DPI look at the screenshot.

--
Tested via, Firefox Beta 15.0 (Beta 2, build #1)
Galaxy Tab 2 7" (Android 4.0.4)
(Reporter)

Comment 1

5 years ago
Created attachment 645767 [details]
Firefox Beta 15.0 (Beta 2) (Screenshot)
(Reporter)

Updated

5 years ago
Keywords: uiwanted
(Reporter)

Updated

5 years ago
Keywords: polish
(Assignee)

Comment 2

5 years ago
I am suspecting that Android takes the drawable from a different folder (though our folders are right.. android does it at times. This was the reason for calling resources as address_bar_bg_tablet.png and so on).
I'll try renaming and see if we get any difference.
(Assignee)

Comment 3

5 years ago
Created attachment 647620 [details] [diff] [review]
Patch

My initial patch has missed adding the files to Makefile.in. They have been added now.
The images weren't perfect (that were about to be added in Makefile.in). They have been replaced.
The layout had to be changed back then, as I felt something is wrong with images (without knowing I didnt add them), and I have reverted the layout changes to be in proportion with phones.
Attachment #647620 - Flags: review?(mark.finkle)
Attachment #647620 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/08dbf37ae570
(Assignee)

Comment 5

5 years ago
Comment on attachment 647620 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: The tab curve will be pixellated in Nexus 7.
Testing completed (on m-c, etc.): Landed in m-i on 08/03
Risk to taking this patch (and alternatives if risky): None. The images are already there. They are just added to Makefile.in (and few images were wrong -- just replaced).
String or UUID changes made by this patch: None.
Attachment #647620 - Flags: approval-mozilla-beta?
Attachment #647620 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/08dbf37ae570
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
status-firefox16: --- → affected
status-firefox17: --- → fixed
Comment on attachment 647620 [details] [diff] [review]
Patch

low risk, mobile only, approving for branches.
Attachment #647620 - Flags: approval-mozilla-beta?
Attachment #647620 - Flags: approval-mozilla-beta+
Attachment #647620 - Flags: approval-mozilla-aurora?
Attachment #647620 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 8

5 years ago
Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/5c93b603dc71
(Reporter)

Updated

5 years ago
status-firefox16: affected → fixed
(Assignee)

Comment 9

5 years ago
Pushed to beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/6109be88ac12
(Reporter)

Updated

5 years ago
status-firefox15: affected → fixed
(Reporter)

Updated

5 years ago
Status: RESOLVED → VERIFIED
status-firefox17: fixed → verified
There is a high resolution quality for the tab curve on Galaxy Tab 2 7" on Firefox 16 beta 5.
status-firefox16: fixed → verified
(Reporter)

Updated

5 years ago
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.