Closed Bug 777378 Opened 8 years ago Closed 6 years ago

Remove SUPPRESS_DEFAULT_RULES

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: ted, Assigned: Sylvestre)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Apparently we stopped using this a long time ago, we should remove the bits that handle it from rules.mk.
Attached patch fix-bug-777378.diff (obsolete) — Splinter Review
Are you sure it is no longer used ?

config/makefiles/xpidl/Makefile.in
is calling it.

Anyway, if you think it is useless, the attached patch fixes it.
Attachment #8339325 - Flags: review?
Assignee: nobody → sylvestre
Attachment #8339325 - Flags: review? → review?(ted)
Comment on attachment 8339325 [details] [diff] [review]
fix-bug-777378.diff

That Makefile didn't exist when I filed this bug, gps added it in bug 850380. Punting review to him.
Attachment #8339325 - Flags: review?(ted) → review?(gps)
Comment on attachment 8339325 [details] [diff] [review]
fix-bug-777378.diff

Review of attachment 8339325 [details] [diff] [review]:
-----------------------------------------------------------------

I /think/ this is safe. Please push to try before landing, just to be sure.
Attachment #8339325 - Flags: review?(gps) → review+
Attachment #8339325 - Attachment is obsolete: true
here is the try tree, before it was closed (cf bug 957502):
https://tbpl.mozilla.org/?tree=Try&rev=642cd37ebfaf

So, it seems it can be checkin, right?
Keywords: checkin-needed
Assignee: sylvestre → sledru
https://hg.mozilla.org/mozilla-central/rev/9b4dfa6818b9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.