Closed
Bug 777378
Opened 13 years ago
Closed 11 years ago
Remove SUPPRESS_DEFAULT_RULES
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: ted, Assigned: Sylvestre)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
2.16 KB,
patch
|
Details | Diff | Splinter Review |
Apparently we stopped using this a long time ago, we should remove the bits that handle it from rules.mk.
Are you sure it is no longer used ?
config/makefiles/xpidl/Makefile.in
is calling it.
Anyway, if you think it is useless, the attached patch fixes it.
Attachment #8339325 -
Flags: review?
Attachment #8339325 -
Flags: review? → review?(ted)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8339325 [details] [diff] [review]
fix-bug-777378.diff
That Makefile didn't exist when I filed this bug, gps added it in bug 850380. Punting review to him.
Attachment #8339325 -
Flags: review?(ted) → review?(gps)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8339325 [details] [diff] [review]
fix-bug-777378.diff
Review of attachment 8339325 [details] [diff] [review]:
-----------------------------------------------------------------
I /think/ this is safe. Please push to try before landing, just to be sure.
Attachment #8339325 -
Flags: review?(gps) → review+
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8339325 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
here is the try tree, before it was closed (cf bug 957502):
https://tbpl.mozilla.org/?tree=Try&rev=642cd37ebfaf
So, it seems it can be checkin, right?
Keywords: checkin-needed
|
|
Assignee | |
Updated•11 years ago
|
Assignee: sylvestre → sledru
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•