777378 - Remove SUPPRESS_DEFAULT_RULES

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Apparently we stopped using this a long time ago, we should remove the bits that handle it from rules.mk.

Comment 1

[sylvestre]

Attachment: fix-bug-777378.diff

Are you sure it is no longer used ?

config/makefiles/xpidl/Makefile.in
is calling it.

Anyway, if you think it is useless, the attached patch fixes it.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8339325 [details] [diff] [review]
fix-bug-777378.diff

That Makefile didn't exist when I filed this bug, gps added it in bug 850380. Punting review to him.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8339325 [details] [diff] [review]
fix-bug-777378.diff

Review of attachment 8339325 [details] [diff] [review]:
-----------------------------------------------------------------

I /think/ this is safe. Please push to try before landing, just to be sure.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: refresh of the patch

Comment 5

[Sylvestre Ledru [:Sylvestre]]

here is the try tree, before it was closed (cf bug 957502):
https://tbpl.mozilla.org/?tree=Try&rev=642cd37ebfaf

So, it seems it can be checkin, right?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b4dfa6818b9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b4dfa6818b9