B2G HAL SIGUSR2 interferes with profiling

RESOLVED FIXED in mozilla17

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: jrmuizel)

Tracking

unspecified
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Right now we can't use the profiler out of the box on b2g because SIGUSR2 is also used by B2G. The reason we use SIGUSR2 is because SIGUSR1 is used by the dalvik VM. Since we have the flexibility on B2G can we change that signal number?
Yes, we can grab one of the SIGRT's.
Actually, we could use SIGUSR1, since we don't have dalvik.
(Assignee)

Comment 3

5 years ago
Created attachment 645877 [details] [diff] [review]
Use SIGUSR1
Attachment #645877 - Flags: review?(jones.chris.g)
Comment on attachment 645877 [details] [diff] [review]
Use SIGUSR1

hg blame says that I pulled SIGUSR2 out of my butt in bug 749551 comment 53, so I don't see anything wrong a priori with switching to SIGUSR1 if it's indeed dalvik using that and not bionic.
Attachment #645877 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5e64fd6e7b2
(Assignee)

Updated

5 years ago
Assignee: nobody → jmuizelaar
https://hg.mozilla.org/mozilla-central/rev/b5e64fd6e7b2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.