Last Comment Bug 777381 - B2G HAL SIGUSR2 interferes with profiling
: B2G HAL SIGUSR2 interferes with profiling
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Jeff Muizelaar [:jrmuizel]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 09:35 PDT by Benoit Girard (:BenWa)
Modified: 2012-07-28 18:37 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use SIGUSR1 (1.06 KB, patch)
2012-07-25 13:55 PDT, Jeff Muizelaar [:jrmuizel]
cjones.bugs: review+
Details | Diff | Review

Description Benoit Girard (:BenWa) 2012-07-25 09:35:20 PDT
Right now we can't use the profiler out of the box on b2g because SIGUSR2 is also used by B2G. The reason we use SIGUSR2 is because SIGUSR1 is used by the dalvik VM. Since we have the flexibility on B2G can we change that signal number?
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-25 10:35:37 PDT
Yes, we can grab one of the SIGRT's.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-25 10:36:14 PDT
Actually, we could use SIGUSR1, since we don't have dalvik.
Comment 3 Jeff Muizelaar [:jrmuizel] 2012-07-25 13:55:46 PDT
Created attachment 645877 [details] [diff] [review]
Use SIGUSR1
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-25 14:03:17 PDT
Comment on attachment 645877 [details] [diff] [review]
Use SIGUSR1

hg blame says that I pulled SIGUSR2 out of my butt in bug 749551 comment 53, so I don't see anything wrong a priori with switching to SIGUSR1 if it's indeed dalvik using that and not bionic.
Comment 5 Jeff Muizelaar [:jrmuizel] 2012-07-27 11:59:36 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5e64fd6e7b2
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:37:13 PDT
https://hg.mozilla.org/mozilla-central/rev/b5e64fd6e7b2

Note You need to log in before you can comment on or make changes to this bug.