WebIDL Codegen (or Parser, don't really care) should ensure that the various infallible annotations are applied to the right things.

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla17
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In particular, we shouldn't accept GetterInfallible or SetterInfallible on methods, and we shouldn't accept SetterInfallible on readonly attrs.
Created attachment 646029 [details] [diff] [review]
Disallow GetterInfallible/SetterInfallible annotations where they don't make sense.
Attachment #646029 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Blocks: 580070
Whiteboard: [need review]
Created attachment 646033 [details] [diff] [review]
Disallow GetterInfallible/SetterInfallible annotations where they don't make sense.
Attachment #646033 - Flags: review?(khuey)
Attachment #646029 - Attachment is obsolete: true
Attachment #646029 - Flags: review?(khuey)
Attachment #646033 - Flags: review?(khuey) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/d34663c1217b
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla17

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d34663c1217b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.