Closed Bug 777463 Opened 12 years ago Closed 12 years ago

Options missing from Firefox Button Menu

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 17

People

(Reporter: jmjjeffery, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Patch v2
1.84 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Tested using the hourly build based on cset: https://hg.mozilla.org/mozilla-central/rev/75d16b99e8ab Click on the 'Firefox button' Note that in the right-column that 'Options' is missing from the list. Options still shows in the Menu list if you press ALT. need some help finding regression window but I'm suspecting https://bugzilla.mozilla.org/show_bug.cgi?id=764872 https://bugzilla.mozilla.org/show_bug.cgi?id=764869 since they are providing a way to hide social functionality, ended up maybe somehow hiding the entire 'Options Button'
Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/be7d963dcc80 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120723220243 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/46bd216c417f Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120723222542 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=be7d963dcc80&tochange=46bd216c417f
Blocks: 764872
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Keywords: regressionwindow-wanted
Attached patch Patch (obsolete) — — Splinter Review
Untested since I had to pull latest from the tree and am rebuilding now, but from discussions in #fx-team, this seems like what we should have done.
Attachment #645880 - Flags: review?(gavin.sharp)
Comment on attachment 645880 [details] [diff] [review] Patch Shouldn't it be after the menuseparator?
Yeah, I wasn't sure if it should be with the other toolbars. Maybe it should be in its own section with its own separator?
Attachment #645880 - Flags: review?(gavin.sharp)
Attached patch Patch v2 — — Splinter Review
Ok I tested this patch and it is also with the toolbar menuitems in the options popup.
Attachment #645880 - Attachment is obsolete: true
Attachment #645892 - Flags: review?(gavin.sharp)
Attachment #645892 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8696db732026
Flags: in-testsuite-
Target Milestone: --- → Firefox 17
Version: Trunk → 17 Branch
https://hg.mozilla.org/mozilla-central/rev/8696db732026
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Tested using cset: https://hg.mozilla.org/mozilla-central/rev/20db7c6d82cc -
Status: RESOLVED → VERIFIED
Target Milestone: Firefox 17 → ---
Version: 17 Branch → Trunk
Hardware: x86_64 → All
Target Milestone: --- → Firefox 17
The above cset (comment 9) does not apply for this bug. I think the commit message should have said bug 775463.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: