Options missing from Firefox Button Menu

VERIFIED FIXED in Firefox 17

Status

()

Firefox
Menus
--
critical
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Jim Jeffery not reading bug-mail 1/2/11, Assigned: jaws)

Tracking

({regression})

Trunk
Firefox 17
All
Windows 7
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Tested using the hourly build based on cset:
https://hg.mozilla.org/mozilla-central/rev/75d16b99e8ab

Click on the 'Firefox button'
Note that in the right-column that 'Options' is missing from the list.

Options still shows in the Menu list if you press ALT.  

need some help finding regression window but I'm suspecting 
https://bugzilla.mozilla.org/show_bug.cgi?id=764872
https://bugzilla.mozilla.org/show_bug.cgi?id=764869

since they are providing a way to hide social functionality, ended up maybe somehow hiding the entire 'Options Button'

Comment 1

5 years ago
Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/be7d963dcc80
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120723220243
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/46bd216c417f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120723222542
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=be7d963dcc80&tochange=46bd216c417f

Updated

5 years ago
Blocks: 764872
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Keywords: regressionwindow-wanted
Created attachment 645880 [details] [diff] [review]
Patch

Untested since I had to pull latest from the tree and am rebuilding now, but from discussions in #fx-team, this seems like what we should have done.
Attachment #645880 - Flags: review?(gavin.sharp)
Comment on attachment 645880 [details] [diff] [review]
Patch

Shouldn't it be after the menuseparator?
Yeah, I wasn't sure if it should be with the other toolbars. Maybe it should be in its own section with its own separator?
Attachment #645880 - Flags: review?(gavin.sharp)
Created attachment 645892 [details] [diff] [review]
Patch v2

Ok I tested this patch and it is also with the toolbar menuitems in the options popup.
Attachment #645880 - Attachment is obsolete: true
Attachment #645892 - Flags: review?(gavin.sharp)
Attachment #645892 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8696db732026
Flags: in-testsuite-
Target Milestone: --- → Firefox 17
Version: Trunk → 17 Branch

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8696db732026
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Tested using cset: https://hg.mozilla.org/mozilla-central/rev/20db7c6d82cc -
Status: RESOLVED → VERIFIED
Target Milestone: Firefox 17 → ---
Version: 17 Branch → Trunk

Updated

5 years ago
Hardware: x86_64 → All
Target Milestone: --- → Firefox 17

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8b3b879bc63f
The above cset (comment 9) does not apply for this bug. I think the commit message should have said bug 775463.
You need to log in before you can comment on or make changes to this bug.