777523 - Remove "XXX bug 3935" annotations in nsCSSPropList.h for properties whose parsed names match their internal names

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

nsCSSPropList.h has some of its properties labeled with "XXX bug 3935".  It has this explanatory note:
> 230 // For notes XXX bug 3935 below, the names being parsed do not correspond
> 231 // to the constants used internally.  It would be nice to bring the
> 232 // constants into line sometime.
http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSPropList.h#228


IIUC, this is meant to cover properties like this one...
> 568 CSS_PROP_DISPLAY(
> 569     -moz-binding,
> 570     binding,
...where we parse the property "-moz-binding" but internally call it "binding" (e.g. eCSSProperty_binding)

However, some of the formerly-moz-prefixed properties in that list are now no longer prefixed, so the parsed & internal property-names are now in agreement.  We should remove the "XXX bug 3935" annotations for these properties.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 645903 [details] [diff] [review]
fix v1

r=dbaron

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1a791c856f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a1a791c856f