Last Comment Bug 777523 - Remove "XXX bug 3935" annotations in nsCSSPropList.h for properties whose parsed names match their internal names
: Remove "XXX bug 3935" annotations in nsCSSPropList.h for properties whose par...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Daniel Holbert [:dholbert]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 15:17 PDT by Daniel Holbert [:dholbert]
Modified: 2012-07-28 18:35 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1 (1.47 KB, patch)
2012-07-25 15:20 PDT, Daniel Holbert [:dholbert]
dbaron: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-07-25 15:17:10 PDT
nsCSSPropList.h has some of its properties labeled with "XXX bug 3935".  It has this explanatory note:
> 230 // For notes XXX bug 3935 below, the names being parsed do not correspond
> 231 // to the constants used internally.  It would be nice to bring the
> 232 // constants into line sometime.
http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSPropList.h#228


IIUC, this is meant to cover properties like this one...
> 568 CSS_PROP_DISPLAY(
> 569     -moz-binding,
> 570     binding,
...where we parse the property "-moz-binding" but internally call it "binding" (e.g. eCSSProperty_binding)

However, some of the formerly-moz-prefixed properties in that list are now no longer prefixed, so the parsed & internal property-names are now in agreement.  We should remove the "XXX bug 3935" annotations for these properties.
Comment 1 Daniel Holbert [:dholbert] 2012-07-25 15:20:59 PDT
Created attachment 645903 [details] [diff] [review]
fix v1
Comment 2 David Baron :dbaron: ⌚️UTC-7 (busy September 14-25) 2012-07-27 15:31:09 PDT
Comment on attachment 645903 [details] [diff] [review]
fix v1

r=dbaron
Comment 3 Daniel Holbert [:dholbert] 2012-07-27 15:54:08 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1a791c856f
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-28 18:35:22 PDT
https://hg.mozilla.org/mozilla-central/rev/7a1a791c856f

Note You need to log in before you can comment on or make changes to this bug.