Remove "XXX bug 3935" annotations in nsCSSPropList.h for properties whose parsed names match their internal names

RESOLVED FIXED in mozilla17

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsCSSPropList.h has some of its properties labeled with "XXX bug 3935".  It has this explanatory note:
> 230 // For notes XXX bug 3935 below, the names being parsed do not correspond
> 231 // to the constants used internally.  It would be nice to bring the
> 232 // constants into line sometime.
http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSPropList.h#228


IIUC, this is meant to cover properties like this one...
> 568 CSS_PROP_DISPLAY(
> 569     -moz-binding,
> 570     binding,
...where we parse the property "-moz-binding" but internally call it "binding" (e.g. eCSSProperty_binding)

However, some of the formerly-moz-prefixed properties in that list are now no longer prefixed, so the parsed & internal property-names are now in agreement.  We should remove the "XXX bug 3935" annotations for these properties.
Created attachment 645903 [details] [diff] [review]
fix v1
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #645903 - Flags: review?(dbaron)
Comment on attachment 645903 [details] [diff] [review]
fix v1

r=dbaron
Attachment #645903 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1a791c856f
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/7a1a791c856f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.