Add a=rtcp-mux SDP attribute support to SIPCC

RESOLVED FIXED

Status

()

Core
WebRTC: Signaling
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emannion, Assigned: emannion)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 645905 [details] [diff] [review]
Add rtcp-mux SDP attribute support to SIPCC

This patch adds rtcp-mux  SDP attribute support to SIPCC SDP component. Along with the attribute getter and setter.  A boolean is stored in each media struct.  media->rtcp-mux
Attachment #645905 - Flags: feedback?(ethanhugg)
Attachment #645905 - Flags: feedback?(ekr)

Comment 1

6 years ago
Comment on attachment 645905 [details] [diff] [review]
Add rtcp-mux SDP attribute support to SIPCC

Review of attachment 645905 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
@@ +3702,5 @@
>      char           *session_pwd;
>      cc_action_data_t  data;
>      int             j=0;
> +    int             rtcpmux = 0;
> +    tinybool       *rtcp_mux = FALSE;

Did you mean to make this a pointer?  Seems it should be a bool.
Attachment #645905 - Flags: feedback?(ethanhugg) → feedback+
(Assignee)

Comment 2

6 years ago
Created attachment 647009 [details] [diff] [review]
Revised: Add rtcp-mux SDP attribute support to SIPCC

Updated after applying Ethan's comments.
Attachment #645905 - Attachment is obsolete: true
Attachment #645905 - Flags: feedback?(ekr)

Comment 4

6 years ago
Created attachment 647195 [details] [diff] [review]
Add  SDP attribute support to SIPCC

Comment 5

6 years ago
Created attachment 647197 [details] [diff] [review]
Add rtcp-mux SDP attribute support to SIPCC

Updated

6 years ago
Attachment #647195 - Attachment is obsolete: true

Updated

6 years ago
Attachment #647009 - Attachment is obsolete: true

Updated

6 years ago
QA Contact: jsmith

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.