Root the minimum XML stuff necessary to pass jstests

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

I was getting (only) two test failures in e4x stuff. I don't really understand why it isn't puking all over the place, but it appears that those tests will pass with some very minimal rooting.
Created attachment 645921 [details] [diff] [review]
Root the minimum XML stuff necessary to pass jstests
Attachment #645921 - Flags: review?(terrence)
Comment on attachment 645921 [details] [diff] [review]
Root the minimum XML stuff necessary to pass jstests

Review of attachment 645921 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Steve Fink [:sfink] from comment #0)
> I was getting (only) two test failures in e4x stuff. I don't really
> understand why it isn't puking all over the place, 

Oh, it does.  Brian added a flag to disable the root analysis if anything touches XML.

> but it appears that those
> tests will pass with some very minimal rooting.

It's a shame we have to muck with this at all.
Attachment #645921 - Flags: review?(terrence) → review+
/home/sfink/src/MI-upstream/rev/bdca2e424ca8
Oops, sorry about that. Rogue script.

http://hg.mozilla.org/integration/mozilla-inbound/rev/bdca2e424ca8
Whiteboard: [js:t]

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bdca2e424ca8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.