Closed
Bug 777546
Opened 13 years ago
Closed 13 years ago
Root the minimum XML stuff necessary to pass jstests
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: sfink, Assigned: sfink)
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
3.25 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
I was getting (only) two test failures in e4x stuff. I don't really understand why it isn't puking all over the place, but it appears that those tests will pass with some very minimal rooting.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #645921 -
Flags: review?(terrence)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 645921 [details] [diff] [review]
Root the minimum XML stuff necessary to pass jstests
Review of attachment 645921 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Steve Fink [:sfink] from comment #0)
> I was getting (only) two test failures in e4x stuff. I don't really
> understand why it isn't puking all over the place,
Oh, it does. Brian added a flag to disable the root analysis if anything touches XML.
> but it appears that those
> tests will pass with some very minimal rooting.
It's a shame we have to muck with this at all.
Attachment #645921 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
/home/sfink/src/MI-upstream/rev/bdca2e424ca8
|
|
Assignee | |
Comment 4•13 years ago
|
||
Oops, sorry about that. Rogue script.
http://hg.mozilla.org/integration/mozilla-inbound/rev/bdca2e424ca8
|
||
Updated•13 years ago
|
Whiteboard: [js:t]
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•