Last Comment Bug 777546 - Root the minimum XML stuff necessary to pass jstests
: Root the minimum XML stuff necessary to pass jstests
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Steve Fink [:sfink] [:s:]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 16:10 PDT by Steve Fink [:sfink] [:s:]
Modified: 2012-07-26 05:09 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Root the minimum XML stuff necessary to pass jstests (3.25 KB, patch)
2012-07-25 16:10 PDT, Steve Fink [:sfink] [:s:]
terrence: review+
Details | Diff | Splinter Review

Description Steve Fink [:sfink] [:s:] 2012-07-25 16:10:14 PDT
I was getting (only) two test failures in e4x stuff. I don't really understand why it isn't puking all over the place, but it appears that those tests will pass with some very minimal rooting.
Comment 1 Steve Fink [:sfink] [:s:] 2012-07-25 16:10:23 PDT
Created attachment 645921 [details] [diff] [review]
Root the minimum XML stuff necessary to pass jstests
Comment 2 Terrence Cole [:terrence] 2012-07-25 16:23:04 PDT
Comment on attachment 645921 [details] [diff] [review]
Root the minimum XML stuff necessary to pass jstests

Review of attachment 645921 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Steve Fink [:sfink] from comment #0)
> I was getting (only) two test failures in e4x stuff. I don't really
> understand why it isn't puking all over the place, 

Oh, it does.  Brian added a flag to disable the root analysis if anything touches XML.

> but it appears that those
> tests will pass with some very minimal rooting.

It's a shame we have to muck with this at all.
Comment 3 Steve Fink [:sfink] [:s:] 2012-07-25 16:31:34 PDT
/home/sfink/src/MI-upstream/rev/bdca2e424ca8
Comment 4 Steve Fink [:sfink] [:s:] 2012-07-25 16:33:05 PDT
Oops, sorry about that. Rogue script.

http://hg.mozilla.org/integration/mozilla-inbound/rev/bdca2e424ca8
Comment 5 Ed Morley [:emorley] 2012-07-26 05:09:14 PDT
https://hg.mozilla.org/mozilla-central/rev/bdca2e424ca8

Note You need to log in before you can comment on or make changes to this bug.