Crontabber has no locking or other protection from being invoked multiple instances from running. This will cause problems e.g. for writing to the state file, logging etc. We should get this in place ASAP.
Did this quickly, based on the existing cron wrapper we use (so it should work etc): https://github.com/mozilla/socorro/pull/734 Avoiding using the "pyjob" bash function since it assumes the job it's calling is in ./scripts while this is not (but does basically this)
Assignee: nobody → rhelmer
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/9b061f127adec13aefecad16e0560b3ae9185fd3 bug 777549 - add a quick wrapper for crontabber to add proper locking https://github.com/mozilla/socorro/commit/f0f6baed925ec4a53159e6ff576e230086f949d0 Merge pull request #734 from rhelmer/bug777549-crontabber-locking bug 777549 - add a quick wrapper for crontabber to add proper locking
This is not optimal in a few ways (should use something standard like flock, we don't need the old way of importing config variables to the env etc) but should work for now.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.