777565 - Bugzilla bugs parsed for reader mode don't remove div overflow

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Go to https://bugzilla.mozilla.org/show_bug.cgi?id=54321
2) Click reader button

Expected result:
Comments are wrapped to screen

Actual result:
Comment divs horizontally overflow the screen, and each comment can be individually scrolled

Comment 1

[Lucas Rocha (:lucasr)]

We need to enable line wrapping on pre/code elements in reader.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Don't overflow pre/code elements in reader, wrap them

Comment 3

[Lucas Rocha (:lucasr)]

This patch fixes pre/code behavior in reader mode.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/5fd8fca1ebea

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

we don't need to track every edge case and polish for reader mode, just bugs that would block us from shipping reader mode in 16. please nominate patches for uplift though, when they are ready.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fd8fca1ebea

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 651607 [details] [diff] [review]
Don't overflow pre/code elements in reader, wrap them

[Approval Request Comment]
User impact if declined: Pre/code elements will completely break reader layout.
Testing completed (on m-c, etc.): Landed a few days ago, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, just a css change.
String or UUID changes made by this patch: None.

Comment 8

[Lucas Rocha (:lucasr)]

Pushed to mozilla-aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/fe1c94dbee7b

Comment 9

[Adrian Tamas (:AdrianT)]

Verified fix on: Firefox Mobile 16 beta 2, Nightly 18.0a1 2012-09-04 and Aurora 17.0a2 2012-09-05 on Samsung Galaxy Tab 2 7.0 (Android 4.0.4).

All text is wrapped and everything looks as it should.