Closed
Bug 777570
Opened 12 years ago
Closed 12 years ago
IonMonkey: visitMathFunctionD() should be isCall().
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: sstangl, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.97 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
LMathFunctionD always performs a call using callWithABI(), but it uses saveVolatile() and restoreVolatile() to preserve register safety. These functions push and pop, respectively, every single XMM register around each LMathFunctionD callsite. This is very slow. By instead marking LMathFunctionD as isCall(), regalloc will have already guaranteed register safety around the LMathFunctionD, perhaps even in a more intelligent manner.
Attachment #645945 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #645945 -
Flags: review?(dvander) → review+
|
Reporter | |
Comment 1•12 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/81146d7c9f51
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•