nsPrincipal deserializes members in wrong order

RESOLVED FIXED in Firefox 17

Status

()

Core
Security: CAPS
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wchen, Assigned: wchen)

Tracking

unspecified
mozilla17
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox17+ fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The order in which members are deserialized do not match the order in which they are serialized.
(Assignee)

Comment 1

5 years ago
Created attachment 645957 [details] [diff] [review]
Make nsPrincipal deserialize members in the order that they are serialized.
Attachment #645957 - Flags: review?(mounir)
Is this a regression from bug 758258?

If so, we need to make sure we fix before this goes on Aurora (and in fact fix ASAP), since this presumably causes sessionstore dataloss...
Blocks: 758258
tracking-firefox17: --- → ?
Attachment #645957 - Flags: review?(mounir) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/5b892ffb1ba9
Flags: in-testsuite?
Keywords: checkin-needed
(Assignee)

Comment 4

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #2)
> Is this a regression from bug 758258?
> 
> If so, we need to make sure we fix before this goes on Aurora (and in fact
> fix ASAP), since this presumably causes sessionstore dataloss...

Yes, this is a regression caused by bug 758258. Here in particular: http://hg.mozilla.org/mozilla-central/diff/04d93909f3de/caps/src/nsPrincipal.cpp
https://hg.mozilla.org/mozilla-central/rev/5b892ffb1ba9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
status-firefox17: --- → fixed
tracking-firefox17: ? → +
Flagging [qa-] as I don't think this needs QA verification. Please correct me if I am wrong.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.