777582 - nsPrincipal deserializes members in wrong order

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[William Chen [:wchen]]

The order in which members are deserialized do not match the order in which they are serialized.

Comment 1

[William Chen [:wchen]]

Attachment: Make nsPrincipal deserialize members in the order that they are serialized.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Is this a regression from bug 758258?

If so, we need to make sure we fix before this goes on Aurora (and in fact fix ASAP), since this presumably causes sessionstore dataloss...

Comment 3

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5b892ffb1ba9

Comment 4

[William Chen [:wchen]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Is this a regression from bug 758258?
> 
> If so, we need to make sure we fix before this goes on Aurora (and in fact
> fix ASAP), since this presumably causes sessionstore dataloss...

Yes, this is a regression caused by bug 758258. Here in particular: http://hg.mozilla.org/mozilla-central/diff/04d93909f3de/caps/src/nsPrincipal.cpp

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5b892ffb1ba9

Comment 6

[u279076]

Flagging [qa-] as I don't think this needs QA verification. Please correct me if I am wrong.