Last Comment Bug 777585 - Make nsIFrame::BuildDisplayListForChild check for clipped SVG on the correct frame
: Make nsIFrame::BuildDisplayListForChild check for clipped SVG on the correct ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jonathan Watt [:jwatt] (Away Jun. 27 - Jul. 13)
:
Mentors:
Depends on:
Blocks: 614732
  Show dependency treegraph
 
Reported: 2012-07-25 17:32 PDT by Jonathan Watt [:jwatt] (Away Jun. 27 - Jul. 13)
Modified: 2012-07-26 14:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.25 KB, patch)
2012-07-25 17:34 PDT, Jonathan Watt [:jwatt] (Away Jun. 27 - Jul. 13)
roc: review+
Details | Diff | Review

Description Jonathan Watt [:jwatt] (Away Jun. 27 - Jul. 13) 2012-07-25 17:32:28 PDT
The patch to add SVG display lists in bug 614732 added a check for SVG with clip property clipping in nsIFrame::BuildDisplayListForChild, but the check should be checking the child, not the current frame.
Comment 1 Jonathan Watt [:jwatt] (Away Jun. 27 - Jul. 13) 2012-07-25 17:34:58 PDT
Created attachment 645966 [details] [diff] [review]
patch
Comment 2 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-07-25 17:36:51 PDT
If you have a test, it would be good to have as a reftest.
Comment 3 Jonathan Watt [:jwatt] (Away Jun. 27 - Jul. 13) 2012-07-26 05:25:03 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3509fe1cad73

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2)
> If you have a test, it would be good to have as a reftest.

I don't, I just noticed the bug in passing.
Comment 4 Matt Brubeck (:mbrubeck) 2012-07-26 14:08:24 PDT
https://hg.mozilla.org/mozilla-central/rev/3509fe1cad73

Note You need to log in before you can comment on or make changes to this bug.