777589 - jstest: Remove a 2 line workaround to a 2 line test fix

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

Oddness in the extreme.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 645968 [details] [diff] [review]
v0

Review of attachment 645968 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/js1_5/extensions/regress-50447-1.js
@@ +102,5 @@
>    var expectedLine = 114;
>    var expectedFileName = 'js1_5/extensions/regress-50447-1.js';
>    if (typeof document == "undefined")
>    {
> +    expectedFileName = expectedFileName;

I'm not going to look at this patch very closely, since it does seem rather odd and if everything works after it, I'm happy.

But why not go ahead and finish simplifying this?

  if (typeof document != "undefined") { ...href.replace... }

The "expectedFileName = expectedFileName" just makes me suspicious of bizarro magic that isn't happening.

Comment 2

[Terrence Cole [:terrence]]

Well, I only looked at code that I know runs during shell tests so that it could get checked in with DONTBUILD.  I'll see if there is more in that section that I can clean up before I commit it.

Comment 3

[Terrence Cole [:terrence]]

Oh, I see what you mean.  I know I was feeling rather tired yesterday, but still, wow.

Comment 4

[Terrence Cole [:terrence]]

Attachment: vFinal: fixed nits

Oh yes, there was a reason that I kept the code that way: the test is checking that the exceptions it raises have the right line number.  I fixed the line numbers for the shell, going to give it a try in the browser to make sure I didn't throw those off.

Comment 5

[Ed Morley [:emorley]]

Push backed out for bustage:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a07ce25de7d

Comment 6

[Terrence Cole [:terrence]]

Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=d7e9281d8857
Checked in at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01b9cf7935be

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01b9cf7935be