jstest: Remove a 2 line workaround to a 2 line test fix

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 645968 [details] [diff] [review]
v0

Oddness in the extreme.
Attachment #645968 - Flags: review?(sphink)
(Assignee)

Updated

5 years ago
Whiteboard: [js:t]
Comment on attachment 645968 [details] [diff] [review]
v0

Review of attachment 645968 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/js1_5/extensions/regress-50447-1.js
@@ +102,5 @@
>    var expectedLine = 114;
>    var expectedFileName = 'js1_5/extensions/regress-50447-1.js';
>    if (typeof document == "undefined")
>    {
> +    expectedFileName = expectedFileName;

I'm not going to look at this patch very closely, since it does seem rather odd and if everything works after it, I'm happy.

But why not go ahead and finish simplifying this?

  if (typeof document != "undefined") { ...href.replace... }

The "expectedFileName = expectedFileName" just makes me suspicious of bizarro magic that isn't happening.
Attachment #645968 - Flags: review?(sphink) → review+
(Assignee)

Comment 2

5 years ago
Well, I only looked at code that I know runs during shell tests so that it could get checked in with DONTBUILD.  I'll see if there is more in that section that I can clean up before I commit it.
(Assignee)

Comment 3

5 years ago
Oh, I see what you mean.  I know I was feeling rather tired yesterday, but still, wow.
(Assignee)

Comment 4

5 years ago
Created attachment 646227 [details] [diff] [review]
vFinal: fixed nits

Oh yes, there was a reason that I kept the code that way: the test is checking that the exceptions it raises have the right line number.  I fixed the line numbers for the shell, going to give it a try in the browser to make sure I didn't throw those off.
Attachment #645968 - Attachment is obsolete: true
Attachment #646227 - Flags: review+
Push backed out for bustage:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a07ce25de7d
(Assignee)

Comment 6

5 years ago
Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=d7e9281d8857
Checked in at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01b9cf7935be
https://hg.mozilla.org/mozilla-central/rev/01b9cf7935be
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.