777593 - Menu dropdown acts weirdly in 15 Beta, 16 Aurora and 17 Nightly but works as intended in 14 Release

Status: RESOLVED WORKSFORME

(Tech Evangelism Graveyard :: English US, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Go to:

http://www.totalrewards.com/total_rewards/overview/overview.jsp

and click on TR Alliances on the left.

Fx 14.0.1 Release: Menu drops down and stays down until clicked. (Same as Chromium nightly and Safari 6)

Fx 15 Beta: Menu drops down, closes up automatically and drops down automatically again.
Fx 16 Aurora: Menu drops down and closes up automatically. There is virtually no way of making the menu stay open.
Fx 17 Nightly: Same as Fx 16 Aurora

I think the behaviour in Fx 14.0.1 Release is correct. Assuming that this is a JS bug, so filing in Core -> JavaScript.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Setting tracking nomination flags, also assuming ESR 10 unaffected because 14 is unaffected.

Comment 2

[Paul Adenot (:padenot)]

I can reproduce on nightly (Linux, 64bits).

Comment 3

[Devdatta Akhawe [:devd]]

confirmed on Aurora 16.0a2 (2012-07-25)

Comment 4

[David Mandelin [:dmandelin]]

This affects all versions back to 3.6, and it's not Firefox's fault; rather, the site has several bugs:

 1. The site includes |main.js| 3 times, which causes the site's jquery ready function to get installed 3 times.
 2. There is buggy code in main.js to set |defaultLeftNav| in the ready function, which causes Sizzle (inside jquery) to throw after the second time. Thus, |initMenu|, which is also called in the ready function, gets called 2 times.
 3. The top page includes |page-init.js| with a deprecated |language| tag, which causes it |page-init.js| to not get loaded in Firefox. But Chrome does load it.
    3a. Even if I remove the |language| tag, |page-init.js| doesn't work in Firefox. It uses a jquery |load|, which happens to return immediately in Firefox. Then it tries to call initMenu, but initMenu hasn't been defined yet because |main.js| (which defines it) is deferred. But in Chrome, the |load| doesn't return until later, when initMenu is defined, so it works.

 1+2+3 together mean that initMenu is called 2x on Firefox, but 3x on Chrome. initMenu installs the click handler for the collapsible menus, so the click handler gets installed 2x on Firefox, 3x on Chrome. 

 Finally, the handler's action is to toggle the menu. So on Firefox it's toggled twice, and thus rolls back up. On Chrome it's toggled 3 times, so that adds up to one toggle.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Given comment 4 I'm untracking this for release.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

The website has been changed to a new layout and the old site layout no longer exists at the URL.

-> WORKSFORME